You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am investigating integrating pipes into a production code base. One of the concern that came out when reviewing the library is its use/definition of macro FWD. Because it's such a common name, there seems to be a good level of risk that including pipes header files might cause problems in some other code area that's completely unrelated.
It seems most of time it's used, it can be replaced with something like std::forward<T>(value) (or FWD's current definition std::forward<decltype(value)>(value). Could that be done? I could submit a pull request some time later if you are busy.
Thanks.
The text was updated successfully, but these errors were encountered:
I am investigating integrating pipes into a production code base. One of the concern that came out when reviewing the library is its use/definition of macro
FWD
. Because it's such a common name, there seems to be a good level of risk that including pipes header files might cause problems in some other code area that's completely unrelated.It seems most of time it's used, it can be replaced with something like
std::forward<T>(value)
(orFWD
's current definitionstd::forward<decltype(value)>(value)
. Could that be done? I could submit a pull request some time later if you are busy.Thanks.
The text was updated successfully, but these errors were encountered: