Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

could using macro FWD be removed? #67

Open
zwangf opened this issue Apr 22, 2021 · 0 comments
Open

could using macro FWD be removed? #67

zwangf opened this issue Apr 22, 2021 · 0 comments

Comments

@zwangf
Copy link

zwangf commented Apr 22, 2021

I am investigating integrating pipes into a production code base. One of the concern that came out when reviewing the library is its use/definition of macro FWD. Because it's such a common name, there seems to be a good level of risk that including pipes header files might cause problems in some other code area that's completely unrelated.

It seems most of time it's used, it can be replaced with something like std::forward<T>(value) (or FWD's current definition std::forward<decltype(value)>(value). Could that be done? I could submit a pull request some time later if you are busy.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant