Merge pull request #4 from wvu-r7/pr/2969

Specs 'n' stuff

Author: mcantoni

lib/rex/text.rb

@@ -32,6 +32,7 @@ module Text
   #
   ##
 
+  TLDs = ['com', 'net', 'org', 'gov', 'biz', 'edu']
   States = ["AK", "AL", "AR", "AZ", "CA", "CO", "CT", "DE", "FL", "GA", "HI",
     "IA", "ID", "IL", "IN", "KS", "KY", "LA", "MA", "MD", "ME", "MI", "MN",
     "MO", "MS", "MT", "NC", "ND", "NE", "NH", "NJ", "NM", "NV", "NY", "OH",
@@ -1581,8 +1582,7 @@ def self.rand_hostname
     (rand(5) + 1).times {
       host.push(Rex::Text.rand_text_alphanumeric(rand(10) + 1))
     }
-    d = ['com', 'net', 'org', 'gov']
-    host.push(d[rand(d.size)])
+    host.push(TLDs[rand(TLDs.size)])
     host.join('.').downcase
   end
 
@@ -1617,16 +1617,12 @@ def self.rand_name_female
 
   # Generate a random mail address
   def self.rand_mail_address
-    d = ['com', 'net', 'org', 'gov', 'biz', 'edu']
-
     mail_address = ''
     mail_address << Rex::Text.rand_name
     mail_address << '.'
     mail_address << Rex::Text.rand_surname
     mail_address << '@'
-    mail_address << Rex::Text.rand_text_alpha(rand(5) + 4).downcase
-    mail_address << '.'
-    mail_address << d[rand(d.size)]
+    mail_address << Rex::Text.rand_hostname
   end
 
 

spec/lib/rex/text_spec.rb

@@ -71,6 +71,49 @@
       end
     end
 
+    context ".rand_surname" do
+      it "should return a random surname" do
+        described_class::Surnames.should include(described_class.rand_surname)
+      end
+    end
+
+    context ".rand_name" do
+      it "should return a random name" do
+        names = described_class::Names_Female + described_class::Names_Male
+        names.should include(described_class.rand_name)
+      end
+    end
+
+    context ".rand_name_female" do
+      it "should return a random female name" do
+        described_class::Names_Female.should include(described_class.rand_name_female)
+      end
+    end
+
+    context ".rand_name_male" do
+      it "should return a random male name" do
+        described_class::Names_Male.should include(described_class.rand_name_male)
+      end
+    end
+
+    context ".rand_mail_address" do
+      it "should return a random mail address" do
+        names = described_class::Names_Female + described_class::Names_Male
+        surnames = described_class::Surnames
+        tlds = described_class::TLDs
+
+        # XXX: This is kinda dirty
+        mail_address = described_class.rand_mail_address.split("@").map { |x| x.split(".") }
+        name, surname = mail_address.first.first, mail_address.first.last
+        domain, tld = "example", mail_address.last.last # Poor man's stubbing to preserve TLD
+
+        names.should include(name)
+        surnames.should include(surname)
+        domain.should eq("example")
+        tlds.should include(tld)
+      end
+    end
+
   end
 end