Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security too weak #7

Open
guillaumeblaquiere opened this issue Oct 27, 2019 · 0 comments
Open

Security too weak #7

guillaumeblaquiere opened this issue Oct 27, 2019 · 0 comments

Comments

@guillaumeblaquiere
Copy link
Contributor

According with my comment here, the security proposed by this packaging is too weak (or even dangerous! -> There is a plain text service-account key file with owner role!)

  1. The role are too wide: As described in this page (in reply to my post), the list of role are separated by an OR. That's why, I only recommend to use the role Cloud Datastore Import Export Admin for accessing to the export feature of Firestore. (the storage admin role is to keep). The aim here is to apply the "least privilege" principle.
  2. Set the JSON key file in clear in environment variable (Base64 = clear plain text, no ciphering, no security) is not recommended. Using ciphering system like Berglas (better solution), or simply using the Cloud Run identity (the best solution) are recommended
jlandure pushed a commit that referenced this issue Nov 16, 2019
* enforce security by using Cloud Run identity

* explain how to use Cloud Run Button without the new service account
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant