Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support landscape mode #20

Open
KaKi87 opened this issue Nov 3, 2020 · 4 comments
Open

Support landscape mode #20

KaKi87 opened this issue Nov 3, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@KaKi87
Copy link

KaKi87 commented Nov 3, 2020

Hello,

I love using Unlauncher on my tablet, but absolutely need landscape mode.

For now I can force it using the Rotation Manager app, but it has a major downside, which is that I have to toggle it off before installing apps or granting permissions then toggle it back on before going to the launcher.

Thanks

@jkuester jkuester added the bug Something isn't working label Dec 1, 2020
@KaKi87
Copy link
Author

KaKi87 commented Feb 21, 2021

Hello, landscape mode now became totally unsupported since the last update.
Could you please do something before it gets so incompatible that you'd decide to mark it wontfix ? Thank you

@jkuester
Copy link
Owner

Just wanted to collect some thoughts on what a solution to this issue would involve.

Support for landscape in Unlauncher was broken when we pulled in changes from Slim-Launcher and the AndroidManifest.xml was hard-coded to only support the portrait screen orientation. To simply re-enable landscape mode, all that needs to happen is replacing that line in the AndroidManifest.xml with android:screenOrientation="fullSensor" (should be able to remove the locked LockedOrientationActivity attribute too).

Unfortunately, just allowing landscape mode really breaks the Unlauncher layout (since it is not responsive). The Options page is basically unusable and most of the home apps are not visible (the ones that are overlap with the quick buttons).

To properly support landscape mode we would need at least:

  • Make Options page Scroll-able #83
  • Responsive layout for the home screen. Maybe something like the screenshot below. The important thing would be to try to keep things simple and preserve all the existing elements on the home screen, but just update their layout....

unlauncherScreenshot

@KaKi87
Copy link
Author

KaKi87 commented Sep 26, 2021

Well, can you at least allow it for now ?
I really have no issue with it on my device.
It's not like you're removing or replacing a feature : it won't break current users' setup.
Thanks

@jkuester
Copy link
Owner

I don't really like the idea of re-enabling a half-broken feature (since I think that most users prefer a UX that only lets them do things that "work").

However, I recognize that more advanced users may prefer to accept the trade-offs of broken functionality in order to address their use case. With that in mind, anyone who wants a version of Unlauncher, in its current state, with landscape mode enabled can download it from the Artifacts section from this CI build.

Disclaimer: The APK from the CI build is signed with a different key than the normal Unlauncher APKs distributed via F-Droid. So, to use the APK from the CI build you will have to uninstall Unlauncher from your device before side-loading the APK. Then, if you ever want to switch back to the version of Unlancher distributed via F-Droid, you will need to uninstall Unlancher from your device before installing the F-Droid version.

I realize this is not an ideal solution and I intend to add proper support for landscape mode and a reactive UI in the future. But since the pace of development on Unlancher is slow (thanks to it just being a side project), hopefully this is acceptable as a temporary solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants