Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(overlay) drop permissions overlay #15370

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

saghul
Copy link
Member

@saghul saghul commented Dec 9, 2024

It covers the entire meeting and it's not helpful. A different version of the same concept might be implemented using less intrusive UX, like a modal.

It covers the entire meeting and it's not helpful. A different version
of the same concept might be implemented using less intrusive UX, like a
modal.
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This pull request was not sent to the PullRequest network because the pull request is a draft.

@damencho
Copy link
Member

Hum, shouldn't we implement that modal first? So, with dropping it, what are we going to show? It will be just the browser prompt, and you can still enter a meeting by ignoring the browser prompt. If you later allow access to the browser, will it automatically turn on video for you, although you did not see any video on pre-join because of missing permissions?

@saghul
Copy link
Member Author

saghul commented Dec 12, 2024

The prompt is pretty "in your face" already. And now we have pre-join enabled by default. None of this was true a few years ago so it was easier to miss.

If you enter a meeting without granting permission and you grant it later, the obvious expectation is that yes, you'll enable the camera.

@damencho
Copy link
Member

So we need the dialog before merging that, as you are not expecting to have video on at that moment, which can lead to awkward moments.

@saghul
Copy link
Member Author

saghul commented Dec 12, 2024

Let's discuss, @yanas was ok with landing this first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants