Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Peer2PeerTest fails #267

Open
TheNetStriker opened this issue Mar 31, 2020 · 2 comments
Open

Peer2PeerTest fails #267

TheNetStriker opened this issue Mar 31, 2020 · 2 comments

Comments

@TheNetStriker
Copy link
Contributor

The Peer2PeerTest always fails on my Jitsi installation. I did take a look at the code and my guess ist that the method APP.conference.getP2PConnectionState() should be used to check the p2p connection instead of APP.conference.getConnectionState().

When I change the method the test is successful on my system.

Could you please check if this is an error in the code or am I doing something wrong here?
@damencho
Copy link
Member

You are right, we haven't ran this test in a while, it was flaky at some point and we disabled it. Feel free to open a PR.

@TheNetStriker
Copy link
Contributor Author

@damencho Thanks for the quick reply. I just created a PR: #268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TheNetStriker @damencho