Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to change ffmpeg parameters for the record #553

Open
ChrisPices opened this issue Nov 28, 2024 · 3 comments
Open

Possibility to change ffmpeg parameters for the record #553

ChrisPices opened this issue Nov 28, 2024 · 3 comments

Comments

@ChrisPices
Copy link

Hey there.

I'd like to know if there's any possibilities to changes some ffmpeg parameters about recordings & streaming.
There is resolution, framerate... already, but i'm looking to change format like mp4, flv, either mp3.
I'd like to record with flv format, case if jibri crashes for any reason, the record isn't corrupted. (mp4 is bcause of broken metadata)

i looked on docker and basic installation, I tryed to find where i could, but i didn't find. And i don't have enough skills to reverse engineering :/

Can you tell me where i can, or if it's possible to implement the option?

Thanks you !

@saghul
Copy link
Member

saghul commented Nov 28, 2024

Hey there!

Currently there are some parameters that can be customized using config options:

the source is here:
fun getFfmpegCommandLinux(ffmpegExecutorParams: FfmpegExecutorParams, sink: Sink): List<String> {

The file container and audio codec are not currently configrable.

You make a great argument towards FLV. At the very least, supporting it sounds something desirable. Would you be open to sending a PR?

/cc @aaronkvanmeerten @bgrozev

@ChrisPices
Copy link
Author

Thanks for reply !

Honestly, i'm not a huge user of github...

I can't make a pull request, by the way i am not a developper aha.

But i think i find where we should work to make it possible :

https://github.com/jitsi/jibri/blob/17ab5bd602edd3ddde787def70ee9576bbe0efa9/src/main/kotlin/org/jitsi/jibri/sink/impl/FileSink.kt

image

The extension variable is fixed, maybe move it to an variable configurable on the reference.conf

Sorry, i'm kinda useless right there, if i can make anything else, just let me know !

@saghul
Copy link
Member

saghul commented Nov 28, 2024

No worries @ChrisPices ! I think you already helped!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants