Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files Missing? #39

Open
goforher opened this issue Sep 25, 2024 · 6 comments
Open

Files Missing? #39

goforher opened this issue Sep 25, 2024 · 6 comments

Comments

@goforher
Copy link

In line 15 of ac.py, the code from ..binary import BitPacker, BitUnpacker references binary, but there is no such folder or dependency package in the project.

@jishengpeng
Copy link
Owner

In line 15 of ac.py, the code from ..binary import BitPacker, BitUnpacker references binary, but there is no such folder or dependency package in the project.

This may not seem important

@goforher
Copy link
Author

OK, thanks

@goforher
Copy link
Author

image Hello, I have a question. Why is the `forward` method in this class not using the lines of code `# residual = residual - quantized.detach()` and `# quantized_out = quantized_out + quantized`, while the `encode` and `decode` methods do? Won't this cause inconsistency between training and inference?

@jishengpeng
Copy link
Owner

image Hello, I have a question. Why is the forward method in this class not using the lines of code # residual = residual - quantized.detach() and # quantized_out = quantized_out + quantized, while the encode and decode methods do? Won't this cause inconsistency between training and inference?

The two functions are not utilized; instead, the forward function is employed.

@goforher
Copy link
Author

Alright, thank you.

@goforher

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants