Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options variable should be optional in sync.read #95

Open
HarelM opened this issue Feb 17, 2022 · 1 comment
Open

Options variable should be optional in sync.read #95

HarelM opened this issue Feb 17, 2022 · 1 comment

Comments

@HarelM
Copy link

HarelM commented Feb 17, 2022

The following is the typings for sync.read:

export namespace sync {
  function read(buffer: BufferInput, options: Options): PNG;
  function write(png: PNG, options: Options): PNG;
}

options in read should be optional according to docs.

@HarelM
Copy link
Author

HarelM commented Feb 17, 2022

Also the return type of sync.write should be ArrayBuffer or something similar I guess and not PNG...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant