Skip to content

Commit 050562b

Browse files
committed
Removed unwanted trace statements. Removed dependence on MonsterDebugger. Added method getConnectionUrl with intention of allowing FlashSocket to be extended.
1 parent c8ea807 commit 050562b

File tree

6 files changed

+16
-33
lines changed

6 files changed

+16
-33
lines changed

bin/Flash-Socket.IO.swc

-26.8 KB
Binary file not shown.

libs/MonsterDebugger.swc

-27.1 KB
Binary file not shown.

src/WebSocket.as

-1
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,6 @@ public class WebSocket extends EventDispatcher {
9999
rawSocket.addEventListener(IOErrorEvent.IO_ERROR, onSocketIoError);
100100
rawSocket.addEventListener(SecurityErrorEvent.SECURITY_ERROR, onSocketSecurityError);
101101
rawSocket.connect(host, port);
102-
trace("connectint", host, port);
103102
}
104103

105104
public function send(encData:String):int {

src/WebSocketMain.as

+6-8
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,6 @@ import mx.events.*;
1717
import mx.utils.*;
1818
import bridge.FABridge;
1919

20-
import com.demonsters.debugger.MonsterDebugger;
21-
2220
public class WebSocketMain extends Sprite implements IWebSocketWrapper{
2321

2422
private var callerUrl:String;
@@ -71,20 +69,20 @@ public class WebSocketMain extends Sprite implements IWebSocketWrapper{
7169
}
7270

7371
public function log(message:String):void {
74-
//if (debug) {
75-
MonsterDebugger.trace(this, message);
72+
if (debug) {
73+
trace("Log: " + message);
7674
//ExternalInterface.call("webSocketLog", encodeURIComponent("[WebSocket] " + message));
77-
//}
75+
}
7876
}
7977

8078
public function error(message:String):void {
81-
MonsterDebugger.trace(this, "Error: "+message);
79+
trace(this, "Error: "+message);
8280
//ExternalInterface.call("webSocketError", encodeURIComponent("[WebSocket] " + message));
8381
}
8482

8583
public function fatal(message:String):void {
86-
MonsterDebugger.trace(this, "Fatal: "+message);
87-
//ExternalInterface.call("webSocketError", encodeURIComponent("[WebSocket] " + message));
84+
trace(this, "Fatal: "+message);
85+
//ExternalInterface.call("webSocketError", encodeURIComponent("[WebSocket] " + message));
8886
throw message;
8987
}
9088

src/bridge/FABridge.as

-1
Original file line numberDiff line numberDiff line change
@@ -402,7 +402,6 @@ public class FABridge extends EventDispatcher implements IMXMLObject
402402
}
403403

404404
result.newRefs[objRef] = className;
405-
//trace("serializing new reference: " + className + " with value" + value);
406405

407406
//the result is a getProperty / invokeMethod call. How can we know how much you will need the object ?
408407
if (keep_refs && should_keep_ref) {

src/com/pnwrain/flashsocket/FlashSocket.as

+10-23
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package com.pnwrain.flashsocket
22
{
33
import com.adobe.serialization.json.JSON;
4-
import com.demonsters.debugger.MonsterDebugger;
54
import com.jimisaacs.data.URL;
65
import com.pnwrain.flashsocket.events.FlashSocketEvent;
76

@@ -60,8 +59,7 @@ package com.pnwrain.flashsocket
6059
//}
6160

6261
this.socketURL = webSocketProtocal+"://" + domain + "/socket.io/1/flashsocket";
63-
//this.socketURL = domain + "/socket.io/1/flashsocket";
64-
this.callerUrl = httpProtocal+"://mobile-games.jimib.co.uk/pong.swf";
62+
this.callerUrl = httpProtocal+"://"+domain;
6563

6664
this.domain = domain;
6765
this.protocol = protocol;
@@ -75,19 +73,21 @@ package com.pnwrain.flashsocket
7573
}
7674

7775
var r:URLRequest = new URLRequest();
78-
var now:Date = new Date();
79-
r.url = httpProtocal+"://" + domain + "/socket.io/1/?time=" + now.getTime();
76+
r.url = getConnectionUrl(httpProtocal, domain);
8077
r.method = URLRequestMethod.POST;
78+
8179
var ul:URLLoader = new URLLoader(r);
8280
ul.addEventListener(Event.COMPLETE, onDiscover);
8381
ul.addEventListener(HTTPStatusEvent.HTTP_STATUS, onDiscoverError);
8482
ul.addEventListener(IOErrorEvent.IO_ERROR , onDiscoverError);
85-
83+
}
84+
85+
protected function getConnectionUrl(httpProtocal:String, domain:String):String
86+
{
87+
return httpProtocal+"://" + domain + "/socket.io/1/?time=" + new Date().getTime();
8688
}
8789

8890
protected function onDiscover(event:Event):void{
89-
MonsterDebugger.trace(this, "onDiscover: "+event.type);
90-
9191
var response:String = event.target.data;
9292
var respData:Array = response.split(":");
9393
sessionID = respData[0];
@@ -113,8 +113,6 @@ package com.pnwrain.flashsocket
113113

114114
}
115115
protected function onHandshake(event:Event):void{
116-
MonsterDebugger.trace(this, "onHandshake: "+event.type);
117-
118116
loadDefaultPolicyFile(socketURL);
119117
webSocket = new WebSocket(this, socketURL, protocol, proxyHost, proxyPort, headers);
120118
webSocket.addEventListener("event", onData);
@@ -128,9 +126,7 @@ package com.pnwrain.flashsocket
128126
}
129127

130128
protected function onDiscoverError(event:Event):void{
131-
MonsterDebugger.trace(this, "onDiscoverError: "+event.type);
132129
if ( event is HTTPStatusEvent ){
133-
MonsterDebugger.trace(this, "onDiscoverError status: "+(event as HTTPStatusEvent).status);
134130
if ( (event as HTTPStatusEvent).status != 200){
135131
//we were unsuccessful in connecting to server for discovery
136132
var fe:FlashSocketEvent = new FlashSocketEvent(FlashSocketEvent.CONNECT_ERROR);
@@ -139,7 +135,6 @@ package com.pnwrain.flashsocket
139135
}
140136
}
141137
protected function onHandshakeError(event:Event):void{
142-
MonsterDebugger.trace(this, "onHandshakeError: "+event.type);
143138
if ( event is HTTPStatusEvent ){
144139
if ( (event as HTTPStatusEvent).status != 200){
145140
//we were unsuccessful in connecting to server for discovery
@@ -150,23 +145,19 @@ package com.pnwrain.flashsocket
150145
}
151146

152147
protected function onClose(event:Event):void{
153-
MonsterDebugger.trace(this, "onClose" + this.channel);
154148
var fe:FlashSocketEvent = new FlashSocketEvent(FlashSocketEvent.CLOSE);
155149
dispatchEvent(fe);
156150
}
157151

158152
protected function onConnect(event:Event):void{
159-
MonsterDebugger.trace(this, "onConnect" + this.channel);
160153
var fe:FlashSocketEvent = new FlashSocketEvent(FlashSocketEvent.CONNECT);
161154
dispatchEvent(fe);
162155
}
163156
protected function onIoError(event:Event):void{
164-
MonsterDebugger.trace(this, "onIoError");
165157
var fe:FlashSocketEvent = new FlashSocketEvent(FlashSocketEvent.IO_ERROR);
166158
dispatchEvent(fe);
167159
}
168160
protected function onSecurityError(event:Event):void{
169-
MonsterDebugger.trace(this, "onSecurityError");
170161
var fe:FlashSocketEvent = new FlashSocketEvent(FlashSocketEvent.SECURITY_ERROR);
171162
dispatchEvent(fe);
172163
}
@@ -190,19 +181,16 @@ package com.pnwrain.flashsocket
190181
//return URLUtil.getServerName(this.callerUrl);
191182
}
192183
public function log(message:String):void {
193-
MonsterDebugger.trace(this, "log: " + message);
194184
if (debug) {
195185
trace("webSocketLog: " + message);
196186
}
197187
}
198188

199189
public function error(message:String):void {
200-
MonsterDebugger.trace(this, "error: " + message);
201190
trace("webSocketError: " + message);
202191
}
203192

204193
public function fatal(message:String):void {
205-
MonsterDebugger.trace(this, "fatal: " + message);
206194
trace("webSocketError: " + message);
207195
}
208196

@@ -238,7 +226,6 @@ package com.pnwrain.flashsocket
238226
public var connecting:Boolean;
239227

240228
private function _onMessage(message:String):void{
241-
trace("_onMessage", message);
242229
//https://github.com/LearnBoost/socket.io-spec#Encoding
243230
/* 0 Disconnect
244231
1:: Connect
@@ -261,7 +248,7 @@ package com.pnwrain.flashsocket
261248
if(dm.endpoint == this.channel){
262249
this._onConnect();
263250
}else{
264-
trace("Connecting to: "+'1::'+this.channel);
251+
log("Connecting to: "+'1::'+this.channel);
265252
//connect to the endpoint
266253
try{
267254
webSocket.send('1::'+this.channel);
@@ -374,7 +361,7 @@ package com.pnwrain.flashsocket
374361
webSocket.send('5:'+messageId+':'+this.channel+':' + com.adobe.serialization.json.JSON.encode({"name":event,"args":msg}));
375362
}
376363
}catch(err:Error){
377-
trace("Unable to send message");
364+
fatal("Unable to send message: "+err.message);
378365
}
379366
}
380367

0 commit comments

Comments
 (0)