Skip to content

Commit ed2ebc2

Browse files
committed
fix: fix some minor permission issue. Add detailed explanation to the running example run_multinode_train.sh
1 parent da91064 commit ed2ebc2

4 files changed

Lines changed: 15 additions & 9 deletions

File tree

‎multi_node/run_multinode_train.sh‎

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,23 @@
11
#!/bin/bash
22

33
# Required environment variables for wan_multinode_train.sh
4+
5+
# core42-4-a08u25:172.29.0.73
46
export COORDINATOR_IP=172.29.0.73
5-
export IMAGE_TAG=jianhan-wan-multinode-train:v1
6-
export MULTI_NODES_LOG_DIR=/home/amd/jianhan/multi_node_log
7-
export SHARE_DOCKERFILE_PATH=/home/amd/jianhan/github/maxdiffusion/multi_node/docker/jax_maxdiffusion_wan2.1_train_inference.ubuntu.amd.Dockerfile
8-
export SHARED_CODE_BASE_PATH=/home/amd/jianhan/github/maxdiffusion
7+
export IMAGE_TAG=your-name-wan-multinode-train:v1
8+
# Please keep MULTI_NODES_LOG_DIR outside SHARED_CODE_BASE_PATH since we are going to sync the whole SHARED_CODE_BASE_PATH
9+
export MULTI_NODES_LOG_DIR=/home/amd/your_dir/multi_node_log
10+
export SHARE_DOCKERFILE_PATH=/home/amd/your_dir/maxdiffusion/multi_node/docker/jax_maxdiffusion_wan2.1_train_inference.ubuntu.amd.Dockerfile
11+
export SHARED_CODE_BASE_PATH=/home/amd/your_dir/maxdiffusion
912
export MAXDIFFUSION_DIR_IN_DOCKER=/app/maxdiffusion
10-
export RUN_NAME=WAN_1_3B_FSDP8
13+
export RUN_NAME=WAN_14B_FSDP8
1114
export REMOVE_IMAGES=n
1215
export REGISTRY_USERNAME=""
1316
export REGISTRY_TOKEN=""
1417
export CHMOD_RUN=n
1518

1619
# Define node list
17-
NODES="core42-5-a08u01,core42-1-a08u07,core42-3-a08u19,core42-4-a08u25"
20+
NODES="core42-1-a08u07,core42-3-a08u19,core42-4-a08u25,core42-5-a08u01"
1821

1922
# 1. Clean and sync codebase
2023
# To remove Docker images during cleanup, uncomment the line below:
@@ -24,4 +27,7 @@ bash wan_multinode_train.sh "$NODES" clean
2427
bash wan_multinode_train.sh "$NODES" build
2528

2629
# # 3. Launch training
30+
# Please put the JAX COORDINATOR to the first of the list. The JAX COORDINATOR node will be launched before others to make sure all nodes can connect to the JAX COORDINATOR service.
31+
# core42-4-a08u25:172.29.0.73
32+
NODES="core42-4-a08u25,core42-1-a08u07,core42-3-a08u19,core42-5-a08u01"
2733
bash wan_multinode_train.sh "$NODES" launch

‎multi_node/wan_multinode_train.sbatch‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ echo "Building the container image on all nodes"
104104
srun bash -c '
105105
MAX_RETRIES=5
106106
INITIAL_DELAY=30 # seconds
107-
MAX_DELAY=1800 # seconds
107+
MAX_DELAY=180 # seconds
108108
RETRY_COUNT=0
109109
110110
while true; do

‎multi_node/wan_multinode_train_clean.sh‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ for node in "${NODES[@]}"; do
161161
continue
162162
}
163163

164-
if rsync -az --delete --info=progress2 -e "ssh" \
164+
if rsync -az --delete --omit-dir-times --info=progress2 -e "ssh" \
165165
"$SHARED_CODE_BASE_PATH/" "$node:$SHARED_CODE_BASE_PATH/" \
166166
> "${LOG_DIR}/sync_${node}.log" 2>&1; then
167167
echo "[${node}] ✓ Sync completed"

‎multi_node/wan_multinode_train_launch.sh‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ fi
5252
readonly IMAGE_TAG="${IMAGE_TAG}"
5353
readonly COORDINATOR_IP="${COORDINATOR_IP}"
5454
readonly JAX_COORDINATOR_PORT=12345
55-
readonly COORDINATOR_TIMEOUT=1800
55+
readonly COORDINATOR_TIMEOUT=180
5656

5757
# Paths configuration (should be set by wrapper script)
5858
readonly MULTI_NODES_LOG_DIR="${MULTI_NODES_LOG_DIR}"

0 commit comments

Comments
 (0)