Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing D10 tests #650

Open
jhedstrom opened this issue Jun 15, 2023 · 2 comments
Open

Fix failing D10 tests #650

jhedstrom opened this issue Jun 15, 2023 · 2 comments

Comments

@jhedstrom
Copy link
Owner

jhedstrom commented Jun 15, 2023

Seeing this fatal error in tests:

PHP Fatal error: Declaration of Drupal\Core\TypedData\Validation\ExecutionContext::setGroup($group) must be compatible with Symfony\Component\Validator\Context\ExecutionContextInterface::setGroup(?string $group): void

See related core issue.

jhedstrom added a commit that referenced this issue Jun 15, 2023
@jhedstrom
Copy link
Owner Author

jhedstrom commented Jun 15, 2023

Updating to 10.1 where the initial error is resolved results in this failure

001 Scenario: Target links within table rows # features/d8.feature:7
      And I should see the link "Add field"  # features/d8.feature:12
        No link to 'Add field' on the page http://drupal/admin/structure/types/manage/article/fields (Exception)

So perhaps the UI has changed in 10.1, and we'll need to either adjust the test or the underlying feature context code.

@jhedstrom
Copy link
Owner Author

The language on the field overview has changed for the link:

Screen Shot 2023-06-16 at 9 54 32 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant