shellcheck'ed

Ran shellcheck (shellcheck.net) on all of these scripts.

Author: jgamblin

EC2/instances.sh

@@ -1,6 +1,6 @@
 #!/bin/bash
 #List Instances In Each Region.
-for region in `aws ec2 describe-regions --output text | cut -f3`
+for region in $(aws ec2 describe-regions --output text | cut -f3)
 do
-     aws ec2 describe-instances --region $region --output text --query 'Reservations[*].Instances[*].[Placement.AvailabilityZone, InstanceId, InstanceType, ImageId, PublicIpAddress ]'
+     aws ec2 describe-instances --region "$region" --output text --query 'Reservations[*].Instances[*].[Placement.AvailabilityZone, InstanceId, InstanceType, ImageId, PublicIpAddress ]'
 done

EC2/noingress.sh

@@ -3,20 +3,20 @@
 #Find Bad Network Rules:
 Open=$(aws ec2 describe-security-groups --filters "Name=ip-permission.cidr,Values=0.0.0.0/0" --query "SecurityGroups[].[GroupId, GroupName]" --output text)
 
-#Clear The Screen to make it pretty.
-printf "\033c"
+#Add a line
+printf "\n"
 
 #Display Title.
 printf "The Following Security Groups Have No Ingress Filtering: \033[0K\r"
 printf '\n'
 
 while read -r line; do
-  GroupId=$(echo $line | awk '{print $1;}')
-  GroupName=$(echo $line | awk '{print $2;}')
+  GroupId=$(echo "$line" | awk '{print $1;}')
+  GroupName=$(echo "$line" | awk '{print $2;}')
   Count=$(aws ec2 describe-network-interfaces --filters "Name=group-id,Values=$GroupId" --query "length(NetworkInterfaces)" --output text)
   if [[ $Count -ne 0 ]]
   then
-    printf "$GroupName($GroupId) is being used on $Count EC2 Server(s)."
+    printf "%s(%s) is being used on %s EC2 Server(s)." "$GroupName" "$GroupId" "$Count"
     printf '\n'
   else
     :

EC2/notused.sh

@@ -1,24 +1,24 @@
 #!/bin/bash
 
 #List SecurityGroups:
-Open=$(aws --profile Alpha ec2 describe-security-groups --query "SecurityGroups[].[GroupId, GroupName]" --output text)
+Open=$(aws ec2 describe-security-groups --query "SecurityGroups[].[GroupId, GroupName]" --output text)
 
-#Clear The Screen to make it pretty.
-printf "\033c"
+#Add a line
+printf "\n"
 
 #Display Title.
 printf "The Following Security Groups Are Not Used: \033[0K\r"
 printf '\n'
 
 while read -r line; do
-  GroupId=$(echo $line | awk '{print $1;}')
-  GroupName=$(echo $line | awk '{print $2;}')
+  GroupId=$(echo "$line" | awk '{print $1;}')
+  GroupName=$(echo "$line" | awk '{print $2;}')
   Count=$(aws ec2 describe-network-interfaces --filters "Name=group-id,Values=$GroupId" --query "length(NetworkInterfaces)" --output text)
   if [[ $Count -ne 0 ]]
   then
     :
   else
-    printf "$GroupName($GroupId)"
+    printf "%s(%s)" "$GroupName" "$GroupId"
     printf '\n'
   fi
 done <<< "$Open"

WAF/waf.sh

@@ -1,29 +1,29 @@
 #!/bin/bash
 # Creates a WAF in AWS via CloudFromation
-# Remove >> /dev/null for verbose output. 
+# Remove >> /dev/null for verbose output.
 
 STACKNAME=$1
 
-#Uncomment 1 Line Below To Select Rule Set:  
+#Uncomment 1 Line Below To Select Rule Set:
 
-#OWASP Default Rules: 
+#OWASP Default Rules:
 TEMPLATELOCATION=https://raw.githubusercontent.com/awslabs/aws-waf-sample/master/waf-owasp-top-10/owasp_10_base.yml
 
-#AWS Deafult Rules: 
+#AWS Deafult Rules:
 #TEMPLATELOCATION=https://s3.amazonaws.com/solutions-reference/aws-waf-security-automations/latest/aws-waf-security-automations.template
 
 #VILIDATION:
 printf '\n'
 printf "Validating WAF Template. \033[0K\r"
 printf '\n'
-aws cloudformation validate-template --template-body $TEMPLATELOCATION >> /dev/null
+aws cloudformation validate-template --template-body "$TEMPLATELOCATION" >> /dev/null
 
 #CREATING STACK:
 printf '\n'
-printf "Creating WAF Template: \033[0K\r" 
+printf "Creating WAF Template: \033[0K\r"
 printf '\n'
-aws cloudformation create-stack --stack-name $STACKNAME --template-body $TEMPLATELOCATION --capabilities CAPABILITY_NAMED_IAM                        
+aws cloudformation create-stack --stack-name "$STACKNAME" --template-body "$TEMPLATELOCATION" --capabilities CAPABILITY_NAMED_IAM
 
 printf '\n'
 printf "Done! Check Cloud Formation Console For Build Process.\033[0K\r"
-printf '\n' 
+printf '\n'