Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions src/HttpLibrary/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,12 @@

from base64 import b64encode
from functools import wraps
from urlparse import urlparse
try:
from urlparse import urlparse
except ImportError:
from urllib.parse import urlparse

import livetest
from . import livetest
import json
import jsonpointer
import jsonpatch
Expand All @@ -13,7 +16,7 @@
def load_json(json_string):
try:
return json.loads(json_string)
except ValueError, e:
except ValueError as e:
raise ValueError("Could not parse '%s' as JSON: %s" % (json_string, e))


Expand Down Expand Up @@ -64,9 +67,10 @@ def __init__(self, http, host=None, scheme='http'):
self.post_process_request(None)

def pre_process_request(self):
if len(self.request_headers.items()) > 0:
request_header_items = list(self.request_headers.items())
if len(request_header_items) > 0:
logger.debug("Request headers:")
for name, value in self.request_headers.items():
for name, value in request_header_items:
logger.debug("%s: %s" % (name, value))
else:
logger.debug("No request headers set")
Expand Down Expand Up @@ -417,7 +421,7 @@ def log_response_headers(self, log_level='INFO'):
Specify `log_level` (default: "INFO") to set the log level.
"""
logger.write("Response headers:", log_level)
for name, value in self.response.headers.items():
for name, value in list(self.response.headers.items()):
logger.write("%s: %s" % (name, value), log_level)

# request headers
Expand Down Expand Up @@ -548,7 +552,7 @@ def stringify_json(self, data):

try:
return json.dumps(data, ensure_ascii=False)
except ValueError, e:
except ValueError as e:
raise ValueError(
"Could not stringify '%r' to JSON: %s" % (data, e))

Expand Down
23 changes: 16 additions & 7 deletions src/HttpLibrary/livetest.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,18 @@

import sys
import webtest
import httplib
import urlparse
from Cookie import BaseCookie, CookieError
try:
import httplib
except ImportError:
import http.client as httplib
try:
import urlparse
except ImportError:
import urllib.parse as urlparse
try:
from Cookie import BaseCookie, CookieError
except ImportError:
from http.cookies import BaseCookie, CookieError
from six.moves import http_cookiejar

conn_classes = {'http': httplib.HTTPConnection,
Expand Down Expand Up @@ -118,7 +127,7 @@ def __init__(self, host, scheme='http', relative_to=None):

def _do_httplib_request(self, req):
"Convert WebOb Request to httplib request."
headers = dict((name, val) for name, val in req.headers.iteritems())
headers = dict((name, val) for name, val in req.headers.items())
if req.scheme not in self.conn:
self._load_conn(req.scheme)

Expand All @@ -130,7 +139,7 @@ def _do_httplib_request(self, req):
res.status = '%s %s' % (webresp.status, webresp.reason)
res.body = webresp.read()
response_headers = []
for headername in dict(webresp.getheaders()).keys():
for headername in list(dict(webresp.getheaders()).keys()):
for headervalue in webresp.msg.getheaders(headername):
response_headers.append((headername, headervalue))
res.headerlist = response_headers
Expand All @@ -145,9 +154,9 @@ def do_request(self, req, status, expect_errors):
headers = {}
if self.cookies:
c = BaseCookie()
for name, value in self.cookies.items():
for name, value in list(self.cookies.items()):
c[name] = value
hc = '; '.join(['='.join([m.key, m.value]) for m in c.values()])
hc = '; '.join(['='.join([m.key, m.value]) for m in list(c.values())])
req.headers['Cookie'] = hc

res = self._do_httplib_request(req)
Expand Down
4 changes: 2 additions & 2 deletions src/rf_httplib_dev_helper.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ def run_cli(args):
import robot
try:
robot.run_cli(args)
except Exception, e:
print e
except Exception as e:
print(e)
import robot.runner
robot.run_from_cli(args, robot.runner.__doc__)