fix: Include ipc sample on Windows as well, and mark it as not implemented.

Author: jeremyko

include/asock/asock_ipc_client.hpp

@@ -8,9 +8,9 @@
 #endif
 
 namespace asock {
-#if defined __APPLE__ || defined __linux__
 class ASockIpcClient: public asock::ASockBase {
 public :
+#if defined __APPLE__ || defined __linux__
     // - If you know the maximum data size you will be sending and receiving in advance, 
     //   it is better to allocate a buffer large enough to match that.
     // - If you do not know the size in advance or if it exceeds the buffer, 
@@ -36,7 +36,20 @@ public :
         sock_usage_ = SOCK_USAGE_IPC_CLIENT;
     }
 #elif WIN32
-    //TODO: windows
+    // TODO: Not implemented on Windows.
+    bool InitIpcClient(const char* sock_path,
+                       int connect_timeout_secs=10,
+                       size_t max_data_len=asock::DEFAULT_BUFFER_SIZE) {
+        err_msg_ = "not implemented";
+        ELOG(err_msg_);
+        return false;
+    }
+
+    void SetUsage() override {
+        err_msg_ = "not implemented";
+        ELOG(err_msg_);
+        sock_usage_ = SOCK_USAGE_UNKNOWN;
+    }
 #endif
 };
 } //namespace

include/asock/asock_ipc_server.hpp

@@ -8,9 +8,9 @@
 #endif
 
 namespace asock {
-#if defined __APPLE__ || defined __linux__
 class ASockIpcServer: public asock::ASockBase {
 public :
+#if defined __APPLE__ || defined __linux__
     // - If you know the maximum data size you will be sending and receiving in advance, 
     //   it is better to allocate a buffer large enough to match that.
     // - If you do not know the size in advance or if it exceeds the buffer, 
@@ -34,9 +34,22 @@ public :
     void SetUsage() override {
         sock_usage_ = SOCK_USAGE_IPC_SERVER;
     }
-};
 #elif WIN32
-    //TODO: windows
+    // TODO: Not implemented on Windows.
+    bool RunIpcServer (const char* sock_path, 
+                       size_t max_data_len=asock::DEFAULT_BUFFER_SIZE,
+                       size_t max_event=asock::DEFAULT_MAX_EVENT){
+        err_msg_ = "not implemented";
+        ELOG(err_msg_);
+        return false;
+    }
+
+    void SetUsage() override {
+        err_msg_ = "not implemented";
+        ELOG(err_msg_);
+        sock_usage_ = SOCK_USAGE_UNKNOWN;
+    }
 #endif
+};
 } //namespace
 #endif

sample/CMakeLists.txt

@@ -27,37 +27,22 @@ elseif(APPLE OR CMAKE_SYSTEM_NAME MATCHES "Linux")
   add_definitions(-Wall -Werror -Wextra -Wpedantic)
 endif()
 
-if(WIN32)
-  set(SAMPLE_FILES
-    client_tcp_comp.cpp
-    client_tcp_eo.cpp
-    client_tcp_inh.cpp
-    client_udp_comp.cpp
-    client_udp_inh.cpp
-    server_tcp_comp.cpp
-    server_tcp_eo.cpp
-    server_tcp_inh.cpp
-    server_udp_comp.cpp
-    server_udp_inh.cpp
-  )
-elseif(APPLE OR CMAKE_SYSTEM_NAME MATCHES "Linux")
-  set(SAMPLE_FILES
-    client_tcp_comp.cpp
-    client_tcp_eo.cpp
-    client_tcp_inh.cpp
-    client_udp_comp.cpp
-    client_udp_inh.cpp
-    server_tcp_comp.cpp
-    server_tcp_eo.cpp
-    server_tcp_inh.cpp
-    server_udp_comp.cpp
-    server_udp_inh.cpp
-    client_ipc_comp.cpp
-    client_ipc_inh.cpp
-    server_ipc_comp.cpp
-    server_ipc_inh.cpp
-  )
-endif()
+set(SAMPLE_FILES
+  client_tcp_comp.cpp
+  client_tcp_eo.cpp
+  client_tcp_inh.cpp
+  client_udp_comp.cpp
+  client_udp_inh.cpp
+  server_tcp_comp.cpp
+  server_tcp_eo.cpp
+  server_tcp_inh.cpp
+  server_udp_comp.cpp
+  server_udp_inh.cpp
+  client_ipc_comp.cpp
+  client_ipc_inh.cpp
+  server_ipc_comp.cpp
+  server_ipc_inh.cpp
+)
 
 foreach(samplefile ${SAMPLE_FILES})
   get_filename_component(exename ${samplefile} NAME_WE)

sample/client_ipc_comp.cpp

@@ -6,6 +6,7 @@
 #include <csignal>
 #include "asock/asock_ipc_client.hpp"
 
+// NOTE: Not implemented on Windows.
 // The buffer must be large enough to hold the entire data.
 #define DEFAULT_PACKET_SIZE 1024
 ///////////////////////////////////////////////////////////////////////////////
@@ -96,7 +97,7 @@ int main(int argc, char* argv[]) {
     while( client.IsConnected() ) {
         std::cin.clear();
         getline(std::cin, user_msg); 
-        int msg_len = user_msg.length();
+        int msg_len = (int)user_msg.length();
         if(msg_len>0) {
             if(! client.SendToServer(user_msg.c_str(),msg_len) ) {
                 std::cerr << client.GetLastErrMsg() <<"\n"; 

sample/client_ipc_inh.cpp

@@ -6,6 +6,7 @@
 #include <csignal>
 #include "asock/asock_ipc_client.hpp"
 
+// NOTE: Not implemented on Windows.
 // The buffer must be large enough to hold the entire data.
 #define DEFAULT_PACKET_SIZE 1024
 ///////////////////////////////////////////////////////////////////////////////
@@ -70,7 +71,7 @@ int main(int argc, char* argv[]) {
     while( client.IsConnected() ) {
         std::cin.clear();
         getline(std::cin, user_msg); 
-        int msg_len = user_msg.length();
+        int msg_len = (int)user_msg.length();
         if(msg_len>0) {
             if(! client.SendToServer(user_msg.c_str(),user_msg.length()) ) {
                 std::cerr << client.GetLastErrMsg() <<"\n"; 

sample/server_ipc_comp.cpp

@@ -4,6 +4,7 @@
 #include <csignal>
 #include "asock/asock_ipc_server.hpp"
 
+// NOTE: Not implemented on Windows.
 // The buffer must be large enough to hold the entire data.
 #define DEFAULT_PACKET_SIZE 1024
 ///////////////////////////////////////////////////////////////////////////////
@@ -100,7 +101,7 @@ int main(int argc, char* argv[]) {
     }
     std::cout << "server started" << "\n";
     while( server.IsServerRunning() ) {
-        sleep(1);
+        std::this_thread::sleep_for(std::chrono::seconds(1));
     }
     std::cout << "server exit...\n";
     exit(EXIT_SUCCESS);

sample/server_ipc_inh.cpp

@@ -4,6 +4,7 @@
 #include <csignal>
 #include "asock/asock_ipc_server.hpp"
 
+// NOTE: Not implemented on Windows.
 // The buffer must be large enough to hold the entire data.
 #define DEFAULT_PACKET_SIZE 1024
 ///////////////////////////////////////////////////////////////////////////////
@@ -74,7 +75,7 @@ int main(int argc, char* argv[]) {
         exit(EXIT_FAILURE);
     }std::cout << "server started" << "\n";
     while( server.IsServerRunning() ) {
-        sleep(1);
+        std::this_thread::sleep_for(std::chrono::seconds(1));
     }
     std::cout << "server exit...\n";
     exit(EXIT_SUCCESS);

test/CMakeLists.txt

@@ -26,20 +26,12 @@ elseif(APPLE OR CMAKE_SYSTEM_NAME MATCHES "Linux")
   add_definitions(-Wall -Werror -Wextra -Wpedantic)
 endif()
 
-if(WIN32)
-  set(TEST_FILES
-    buffer_test.cpp
-    tcp_test.cpp
-    udp_test.cpp
-  )
-elseif(APPLE OR CMAKE_SYSTEM_NAME MATCHES "Linux")
-  set(TEST_FILES
-    buffer_test.cpp
-    tcp_test.cpp
-    udp_test.cpp
-    ipc_test.cpp
-  )
-endif()
+set(TEST_FILES
+  buffer_test.cpp
+  tcp_test.cpp
+  udp_test.cpp
+  ipc_test.cpp
+)
 
 enable_testing()
 find_package(GTest CONFIG REQUIRED)

test/ipc_test.cpp

@@ -7,7 +7,7 @@
 #include "asock/asock_ipc_server.hpp"
 
 #define DEFAULT_PACKET_SIZE 1024
-
+// NOTE: Not implemented on Windows.
 // This file is created in the current directory and automatically deleted.
 #define TEST_IPC_PATH "asock.test.ipc"