Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disconnect event is never called #7

Open
cyraxx opened this issue Nov 16, 2020 · 0 comments
Open

disconnect event is never called #7

cyraxx opened this issue Nov 16, 2020 · 0 comments
Assignees
@jensstigaard
Labels
bug Something isn't working

Comments

@cyraxx
Copy link
Contributor

cyraxx commented Nov 16, 2020

CUSTOM_LISTENER_TYPES in connection-tcp.ts includes an event type disconnect.

This event doesn't seem to ever be called. I'm not sure what the intention behind the event was but I suspect it might not be actually needed as the socket's close event can be used instead.
@jensstigaard jensstigaard self-assigned this Apr 19, 2021
@jensstigaard jensstigaard added the bug Something isn't working label Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jensstigaard jensstigaard

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cyraxx @jensstigaard