-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jio-locale attempts to load from the wrong location #64
Comments
i don't think it does either of those things, I think that's just the source map saying where the initial location was. https://github.com/jenkins-infra/jenkins-io-components/blob/main/src/jio-locale.ts#L19 The error message is just saying your browser doesn't match a locale we have translations for, so goes back to default |
Browser tools complain about: |
huh weird, looks like its something todo with source maps. Maybe i need to include src in the packagefile or something for it to expand properly. I originally tried to strip out anything that wasn't needed to reduce file size, but the cdn doesn't download the entire package, just files it needs. Its just a warning doesn't really break anything, but good to fix. |
ag jio-locale.ts build/jio-locale.cjs.js.map build/jio-locale.esm.js.map |
On plugins.jenkins.io I noticed that jio components complain about the wrong locale code:
The script points to https://cdn.jsdelivr.net/npm/@jenkinsci/[email protected]/src/jio-locale.ts, however, should point to the declaration file located at https://cdn.jsdelivr.net/npm/@jenkinsci/[email protected]/build/jio-locale.d.ts
The text was updated successfully, but these errors were encountered: