Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spaceship breaks nested tables in very specific circumstance. #97

Open
vincerubinetti opened this issue Mar 25, 2024 · 0 comments
Open

Comments

@vincerubinetti
Copy link

Here's the code that causes the issue:

<table>
  <tr>
    <td>test</td>
    <td>test</td>
  </tr>
  <tr>
    <td>test</td>
    <td>
      <span>test</span>

      <table>
        <tr>
          <td>test</td>
          <td>test</td>
          <td>test</td>
        </tr>
      </table>
    </td>
  </tr>
</table>

The result:

Screenshot 2024-03-25 at 5 47 22 PM

If I wrap the nested <span> and <table> in a single <div>, it works as expected:

Screenshot 2024-03-25 at 5 48 51 PM

Initially I thought this must've been an issue with Jekyll's markdown parsers. See these issues for more information and more cases of odd/wrong behavior:

gettalong/kramdown#803
kramdown/parser-gfm#39

But then I tested those gems directly, and they didn't produce the problems. Eventually I narrowed down the problem to just jekyll-spaceship. If I have it on, this breaks.

Here's a minimal reproducible example. If you comment out the spaceship plugin in the gemfile, it works.

minimal-reproduction.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant