Fix build not using project collection global properties (#146)

Also bring back ability to build in-memory projects

Author: jeffkl

src/Microsoft.Build.Utilities.ProjectCreation.UnitTests/BuildTests.cs

@@ -134,6 +134,23 @@ public void CanRestoreAndBuild()
             buildOutput.MessageEvents.High.ShouldContain(i => i.Message == "Building...", buildOutput.GetConsoleLog());
         }
 
+        [Fact]
+        public void ProjectWithGlobalPropertiesUsedDuringBuild()
+        {
+            ProjectCollection projectCollection = new ProjectCollection(new Dictionary<string, string>
+            {
+                ["Property1"] = "F6EBAC88A10E453B9AF8FA656A574737",
+            });
+
+            ProjectCreator creator = ProjectCreator.Create(projectCollection: projectCollection)
+                .TaskMessage("$(Property1)", MessageImportance.High)
+                .TryBuild(out bool result, out BuildOutput buildOutput);
+
+            result.ShouldBeTrue(buildOutput.GetConsoleLog());
+
+            buildOutput.Messages.Last().ShouldBe("F6EBAC88A10E453B9AF8FA656A574737");
+        }
+
         [Fact]
         public void ProjectCollectionLoggersWork()
         {
@@ -222,12 +239,12 @@ public void ProjectCollectionLoggersWorkWithRestore()
         }
 
         [Fact]
-        public void ProjectWithNoPathBuildThrowsInvalidOperationException()
+        public void ProjectWithNoPathRestoreThrowsInvalidOperationException()
         {
             InvalidOperationException exception = Should.Throw<InvalidOperationException>(() =>
             {
                 ProjectCreator.Templates.LogsMessage("6E83EF78-959F-45A2-9FE3-08BAD99C0F92")
-                    .TryBuild(out bool _);
+                    .TryRestore(out bool _);
             });
 
             exception.Message.ShouldBe("Project has not been given a path to save to.");

src/Microsoft.Build.Utilities.ProjectCreation/ProjectCreator.Build.cs

@@ -2,6 +2,7 @@
 //
 // Licensed under the MIT license.
 
+using Microsoft.Build.Evaluation;
 using Microsoft.Build.Execution;
 using System;
 using System.Collections.Generic;
@@ -491,8 +492,6 @@ private void Build(bool restore, string[]? targets, IDictionary<string, string>?
         {
             targetOutputs = null;
 
-            Save();
-
             if (restore)
             {
                 Restore(globalProperties, buildOutput, out result, out targetOutputs);
@@ -503,8 +502,21 @@ private void Build(bool restore, string[]? targets, IDictionary<string, string>?
                 }
             }
 
+            ProjectInstance projectInstance;
+
+            if (globalProperties != null)
+            {
+                TryGetProject(out Project project, globalProperties);
+
+                projectInstance = project.CreateProjectInstance();
+            }
+            else
+            {
+                projectInstance = ProjectInstance;
+            }
+
             BuildResult buildResult = BuildManagerHost.Build(
-                FullPath,
+                projectInstance,
                 targets!,
                 globalProperties!,
                 new List<Framework.ILogger>(ProjectCollection.Loggers.Concat(buildOutput.AsEnumerable())),

src/Microsoft.Build.Utilities.ProjectCreation/ProjectCreator.Project.cs

@@ -36,7 +36,7 @@ public Project Project
             {
                 if (_project == null)
                 {
-                    TryGetProject(out _project, _globalProperties, string.IsNullOrEmpty(RootElement.ToolsVersion) ? null : RootElement.ToolsVersion, ProjectCollection);
+                    TryGetProject(out _project, _globalProperties);
                 }
 
                 _project.ReevaluateIfNecessary();
@@ -69,8 +69,8 @@ public ProjectCreator TryGetProject(
             project = new Project(
                 RootElement,
                 globalProperties,
-                toolsVersion,
-                projectCollection ?? ProjectCollection.GlobalProjectCollection,
+                toolsVersion ?? (string.IsNullOrEmpty(RootElement.ToolsVersion) ? null : RootElement.ToolsVersion),
+                projectCollection ?? ProjectCollection,
                 projectLoadSettings);
 
             return this;