Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the current "Upgrade pip" task actually doing anything? #187

Open
YPCrumble opened this issue Aug 3, 2022 · 1 comment
Open

Is the current "Upgrade pip" task actually doing anything? #187

YPCrumble opened this issue Aug 3, 2022 · 1 comment

Comments

@YPCrumble
Copy link
Collaborator

In roles/base/tasks/main.yml we have this task:

- name: Upgrade pip
  pip: name=pip state=latest
  tags:
    - packages
    - skip_ansible_lint

It appears that this command runs outside of the virtualenvironment, so I'm not sure why we need to upgrade pip here. This also begs the question as to whether we need to move this task so that it's part of the sequence where the virtualenv is already activated instead of here, where we're installing system packages on Ubuntu.

@StuartMacKay
Copy link
Contributor

Can confirm that pip is not updated since the date of the first install.

If all the package version numbers are pinned then it does not matter if pip is upgraded automatically. If you do upgrade anything then it would be important to have the pip version locally or on staging the same as prod to avoid any surprises on deploy. If any mismatch occurred it would be between local and prod which would mean, if you tend to deploy straight to prod (which I do), that you'd need to keep pip versions reasonably in sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants