-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define the docker image contract #1
Comments
Oh. I almost forgot about that, as I'm not really using jbake with docker at the moment. But I started an experiment with jbake source as a git submodule to build the docker image from it. There is also a problem at the moment with network binding as jbake serve binds to localhost. |
Oh I got you wrong. I think the purpose of this image was it to be used in a ci build pipeline. |
I see. Well, I can see at least 2 docker image types with JBake:
So this issue is basically asking - which of these does this repo pursue? Regarding dockerization implementation - I strongly recommend having a look at docker-maven-plugin which makes building and testing the image a piece of cake. It may seem a little bit strange at first sight, but it's very logical, reduces boilerplate, creates optimized Dockerfile, makes releasing of the image easier (integrates with maven's paradigms), and working with the result is a pleasure. |
The initial reason this was created was to enable jbake.org to be automatically updated using GitLab Pages and their CI system. However I don't use Docker much at all, so my knowledge is limited. Couldn't option 2 be used in a CI pipeline too? Should option 2 be the first goal to aim for? Then build on that? |
We are using the second version for the build at gitlab already. Anyways...I prefer the second version over the first one for now. @manikmagar Do you mind to release a 2.6.2 version of your javastreets image until we decide where we go from here. The docker image build process should be part of the release, that way the release note on the homepage could be baked directly with a fresh version. That would be a nice goal. |
I have pushed a newer version of the javastreets/jbake image with JBake 2.6.2. In addition to that, I also wanted to update https://github.com/jbake-org/jbake.org/blob/master/.gitlab-ci.yml to use @ancho Yes, I think we should add this to build/release pipeline. |
Currently, I only see a branch with an image which runs
jbake -b -s
on a given content.That's a good start. But we could create an image which would periodically check a git repository and on change, run
jbake
and push the result to some other repository. It could be a simple cron task, but also jenkins-based solution (I prefer the earlier).That way, one could just set up a JBake service in kubernetes and forget it until an upgrade is needed.
Is there a demand for such image?
The text was updated successfully, but these errors were encountered: