Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code cleanup #40

Open
jazzsequence opened this issue Sep 28, 2015 · 1 comment
Open

code cleanup #40

jazzsequence opened this issue Sep 28, 2015 · 1 comment
Assignees
@jazzsequence
Labels
priority-high
Milestone
2.0

Comments

@jazzsequence
Copy link
Owner

there's a lot of ugly code in here and a lot of really large functions. not even sure where to start with #21 without cleaning a lot of this stuff up.
@jazzsequence jazzsequence added this to the 1.5 milestone Sep 28, 2015
@jazzsequence jazzsequence self-assigned this Sep 28, 2015
jazzsequence added a commit that referenced this issue Sep 28, 2015
@jazzsequence
some inline comments so we know what all these freaking brackets are for
547d813 
#40
jazzsequence added a commit that referenced this issue Sep 28, 2015
@jazzsequence
no format int values, just use true/false
ba196ad 
#40
jazzsequence added a commit that referenced this issue Sep 28, 2015
@jazzsequence
endwhile and endif on two lines
0129405 
#40
jazzsequence added a commit that referenced this issue Sep 28, 2015
@jazzsequence
capitalize inline comments
b721e0d 
#40
jazzsequence added a commit that referenced this issue Oct 5, 2015
@jazzsequence
moves the add/remove caps into their own method inside a new class ju…
f4e3cb4 
…st for roles and capabilities

#40
jazzsequence added a commit that referenced this issue Oct 5, 2015
@jazzsequence
use new remove_terms method in taxonomy class to remove all auto-inse…
1213aca 
…rted taxonomy terms

#40
jazzsequence added a commit that referenced this issue Oct 5, 2015
@jazzsequence
adds a function to get WP_Query arguments by values that are passed i…
d4f3308 
…nto it. This is done instead of having a bunch of checks inside the create_shortcode method.

#40
jazzsequence added a commit that referenced this issue Oct 5, 2015
@jazzsequence
method to handle the review author markup
7bc06ec 
#40
jazzsequence added a commit that referenced this issue Oct 5, 2015
@jazzsequence
method to handle the reading level markup
bf05e99 
#40
jazzsequence added a commit that referenced this issue Oct 5, 2015
@jazzsequence
method to handle the stock markup
76b41ee 
#40
jazzsequence added a commit that referenced this issue Oct 5, 2015
@jazzsequence
method to figure out the orderby parameters
0e4e34b 
#40
jazzsequence added a commit that referenced this issue Oct 5, 2015
@jazzsequence
method to return a "no books found" output if there are no books
3650126 
#40
jazzsequence added a commit that referenced this issue Oct 5, 2015
@jazzsequence
handle all the loop stuff in a separate method just for the loop.
3222c8c 
#40
@jazzsequence
Copy link
Owner Author

This branch/issue has gotten super stale and I think I need a rewrite to the rewrite. Entire plugin architecture needs to be rethought/rebuilt and thinking the whole plugin should be written using namespaces.

@jazzsequence jazzsequence modified the milestones: 1.5, 2.0 Sep 25, 2017
@jazzsequence jazzsequence mentioned this issue Sep 25, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jazzsequence jazzsequence

Labels
priority-high
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
1 participant
@jazzsequence