-
-
Notifications
You must be signed in to change notification settings - Fork 258
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Added --users option to waffle_flag management command
Administrators may pass the `--users` option to activate a flag for a set of users, identified by their usernames and/or email addresses.
- Loading branch information
1 parent
06f98e2
commit 5c715be
Showing
3 changed files
with
80 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,7 @@ dist | |
*test.db | ||
.coverage | ||
.idea/ | ||
*.iml | ||
.project | ||
.pydevproject | ||
.settings | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ | |
|
||
import six | ||
from django.core.management import call_command, CommandError | ||
from django.contrib.auth.models import Group | ||
from django.contrib.auth.models import Group, User | ||
|
||
from waffle import get_waffle_flag_model | ||
from waffle.models import Sample, Switch | ||
|
@@ -120,7 +120,7 @@ def test_list(self): | |
call_command('waffle_flag', list_flags=True, stdout=stdout) | ||
expected = 'Flags:\nNAME: test\nSUPERUSERS: True\nEVERYONE: None\n' \ | ||
'AUTHENTICATED: False\nPERCENT: None\nTESTING: False\n' \ | ||
'ROLLOUT: False\nSTAFF: False\nGROUPS: []' | ||
'ROLLOUT: False\nSTAFF: False\nGROUPS: []\nUSERS: []' | ||
actual = stdout.getvalue().strip() | ||
self.assertEqual(actual, expected) | ||
|
||
|
@@ -143,6 +143,52 @@ def test_group_append(self): | |
['waffle_group', 'append_group']) | ||
self.assertIsNone(flag.everyone) | ||
|
||
def test_user(self): | ||
""" The command should replace a user to a flag.""" | ||
original_user = User.objects.create_user('waffle_test') | ||
User.objects.create_user('add_user') | ||
flag = get_waffle_flag_model().objects.create(name='test') | ||
flag.users.add(original_user) | ||
flag.refresh_from_db() | ||
|
||
self.assertEqual(list(flag.users.values_list('username', flat=True)), | ||
['waffle_test']) | ||
|
||
call_command('waffle_flag', 'test', user=['add_user']) | ||
|
||
flag.refresh_from_db() | ||
self.assertEqual(list(flag.users.values_list('username', flat=True)), | ||
['add_user']) | ||
self.assertIsNone(flag.everyone) | ||
|
||
def test_user_append(self): | ||
""" The command should append a user to a flag.""" | ||
original_user = User.objects.create_user('waffle_test') | ||
User.objects.create_user('append_user') | ||
User.objects.create_user('append_user_email', email='[email protected]') | ||
flag = get_waffle_flag_model().objects.create(name='test') | ||
flag.users.add(original_user) | ||
flag.refresh_from_db() | ||
|
||
self.assertEqual(list(flag.users.values_list('username', flat=True)), | ||
['waffle_test']) | ||
|
||
call_command('waffle_flag', 'test', user=['append_user'], | ||
append=True) | ||
|
||
flag.refresh_from_db() | ||
self.assertEqual(list(flag.users.values_list('username', flat=True)), | ||
['waffle_test', 'append_user']) | ||
self.assertIsNone(flag.everyone) | ||
|
||
call_command('waffle_flag', 'test', user=['[email protected]'], | ||
append=True) | ||
|
||
flag.refresh_from_db() | ||
self.assertEqual(list(flag.users.values_list('username', flat=True)), | ||
['waffle_test', 'append_user', 'append_user_email']) | ||
self.assertIsNone(flag.everyone) | ||
|
||
|
||
class WaffleSampleManagementCommandTests(TestCase): | ||
def test_create(self): | ||
|