Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace ethtool invocation with go packages #317

Open
ffromani opened this issue May 10, 2022 · 1 comment · May be fixed by #321
Open

replace ethtool invocation with go packages #317

ffromani opened this issue May 10, 2022 · 1 comment · May be fixed by #321
Assignees
@ffromani

Comments

@ffromani
Copy link
Collaborator

To get the network interface properties on linux, we invoke the ethtool command. This works, but we can simplify our flow and avoid to depend on a external, not-installed-by-default tool by consuming go packages. We should evaluate this option and change accordingly if we reach consensus.
@ffromani ffromani self-assigned this May 10, 2022
@ffromani
Copy link
Collaborator Author

this can probably be a post 1.0.0 item

This was referenced May 10, 2022
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ffromani ffromani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

net: replace the ethtool external program calls with the safchain/ethtool package ffromani/ghw
1 participant
@ffromani