Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set_ncomp has to propagate to groups #560

Open
michaeldeistler opened this issue Dec 19, 2024 · 1 comment · May be fixed by #597
Open

set_ncomp has to propagate to groups #560

michaeldeistler opened this issue Dec 19, 2024 · 1 comment · May be fixed by #597
Labels
bug Something isn't working

Comments

@michaeldeistler
Copy link
Contributor

When using set_ncomp the groups get messed up because they do not get updated.
@michaeldeistler michaeldeistler added the bug Something isn't working label Dec 19, 2024
@jnsbck
Copy link
Contributor

jnsbck commented Dec 19, 2024

Good catch! I did not think of this. We should add a test for this as well!

@michaeldeistler michaeldeistler linked a pull request Feb 26, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes for groups after .set_ncomp() jaxleyverse/jaxley
2 participants
@michaeldeistler @jnsbck