Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing pytests #9

Open
javatarz opened this issue Oct 7, 2019 · 5 comments
Open

Add missing pytests #9

javatarz opened this issue Oct 7, 2019 · 5 comments
Assignees
Labels
good first issue Good for newcomers hacktoberfest Candidate card for hacktoberfest help wanted Extra attention is needed

Comments

@javatarz
Copy link
Owner

javatarz commented Oct 7, 2019

The codebase is small but doesn't have pytest yet. Need to add them

@javatarz javatarz added help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest Candidate card for hacktoberfest labels Oct 7, 2019
@adityaarakeri
Copy link

i can implement this, watch out for my PR

@javatarz javatarz assigned javatarz and adityaarakeri and unassigned javatarz Oct 7, 2019
@javatarz
Copy link
Owner Author

javatarz commented Oct 7, 2019

Thank you @adityaarakeri ^_^ Can't wait. If you have any questions, please let me know.

Can you add a simple section on the readme (like a developers guide) on the command to execute before submitting a PR? In the future, I'd love for all developers to run tests before they send a PR.

I can take that and also add a simple travis pipeline to ensure all PR submissions are tested.

@AminuBishir
Copy link

Is this issue still open??

@javatarz
Copy link
Owner Author

javatarz commented Oct 7, 2019 via email

javatarz added a commit that referenced this issue Oct 13, 2019
javatarz added a commit that referenced this issue Oct 13, 2019
javatarz added a commit that referenced this issue Oct 13, 2019
javatarz added a commit that referenced this issue Oct 13, 2019
@javatarz
Copy link
Owner Author

Hey @adityaarakeri, let me know how the PR's going for you. I've added a couple of tests because I needed to setup the pipeline. If you aren't working on it, let me know. There's others such as @AminuBishir who'd like to take a crack at this.

@AminuBishir, if there's no update on this by tomorrow, this issue is fair game. Let me know if you'd like to pick it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest Candidate card for hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants