-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing pytests #9
Comments
i can implement this, watch out for my PR |
Thank you @adityaarakeri ^_^ Can't wait. If you have any questions, please let me know. Can you add a simple section on the readme (like a developers guide) on the command to execute before submitting a PR? In the future, I'd love for all developers to run tests before they send a PR. I can take that and also add a simple travis pipeline to ensure all PR submissions are tested. |
Is this issue still open?? |
Hey @AminuBishir, thank you for your interest. @adityarakeri has picked this up (first dibs) :) Let's give him a week. If I don't see a PR, I can make ticket open for everyone :)
|
Hey @adityaarakeri, let me know how the PR's going for you. I've added a couple of tests because I needed to setup the pipeline. If you aren't working on it, let me know. There's others such as @AminuBishir who'd like to take a crack at this. @AminuBishir, if there's no update on this by tomorrow, this issue is fair game. Let me know if you'd like to pick it up. |
The codebase is small but doesn't have
pytest
yet. Need to add themThe text was updated successfully, but these errors were encountered: