Skip to content

Commit 38f03e7

Browse files
authoredJul 6, 2022
Bump datadog/dd-trace-java-docker-build image (DataDog#3631)
* Bump to datadog/dd-trace-java-docker-build:luhenry_upgrade-java image * Use common mvnw command * Ensure tests work when it's Oracle OpenJDK 8 * Fix spotless * Fix missing mvnw * Print gradlew info log level * Revert "Print gradlew info log level" This reverts commit 2b5ed42. * Info level logs for IBM8 smoke tests * fixup! Info level logs for IBM8 smoke tests * Following merge of Docker build file * Remove info log level for gradle * fixup! Following merge of Docker build file
1 parent b8b6739 commit 38f03e7

File tree

9 files changed

+10
-9
lines changed

9 files changed

+10
-9
lines changed
 

‎.circleci/config.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -425,7 +425,7 @@ jobs:
425425
- run:
426426
name: Test Published Dependencies
427427
command: |
428-
mvn_local_repo=$(mvn help:evaluate -Dexpression=settings.localRepository -q -DforceStdout)
428+
mvn_local_repo=$(./mvnw help:evaluate -Dexpression=settings.localRepository -q -DforceStdout)
429429
rm -rf "${mvn_local_repo}/com/datadoghq"
430430
export GRADLE_OPTS="-Dorg.gradle.jvmargs='-Xmx1750M -Xms256M -XX:ErrorFile=/tmp/hs_err_pid%p.log'"
431431
./gradlew publishToMavenLocal << pipeline.parameters.gradle_flags >> --max-workers=3

‎dd-java-agent/agent-profiling/profiling-controller/src/test/java/com/datadog/profiling/controller/ControllerFactoryTest.java

+7-6
Original file line numberDiff line numberDiff line change
@@ -37,14 +37,15 @@ public void testCreateControllerJava8() {
3737
+ ", runtimeName="
3838
+ javaRuntimeName
3939
+ "; it requires ";
40-
if ("Azul Systems, Inc.".equals(javaVendor)) {
40+
if (javaVendor.equals("Azul Systems, Inc.")) {
4141
expected += "Zulu Java 8 (1.8.0_212+).";
42-
} else if ("Java(TM) SE Runtime Environment".equals(javaRuntimeName)
43-
&& "Oracle Corporation".equals(javaVendor)
44-
&& javaVersion.startsWith("1.8")) {
45-
// condition for OracleJRE8 (with proprietary JFR inside)
42+
} else if (javaVendor.equals("Oracle Corporation") && !javaRuntimeName.startsWith("OpenJDK")) {
43+
// condition for Oracle JDK 8 (with proprietary JFR inside)
4644
expected += "Oracle JRE/JDK 8u40+";
47-
} else if ("OpenJDK Runtime Environment".equals(javaRuntimeName)) {
45+
} else if (javaVendor.equals("Oracle Corporation") && javaRuntimeName.startsWith("OpenJDK")) {
46+
// condition for Oracle OpenJDK 8 (with open JFR inside)
47+
expected += "1.8.0_272+ OpenJDK builds (upstream)";
48+
} else if (javaRuntimeName.startsWith("OpenJDK")) {
4849
expected +=
4950
"1.8.0_272+ OpenJDK builds from the following vendors: AdoptOpenJDK, Eclipse Temurin, Amazon Corretto, Azul Zulu, BellSoft Liberica.";
5051
} else {

‎dd-java-agent/instrumentation/mule-4/mule-4.gradle

+1-1
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ tasks.register('extractMuleServices', Sync) {
108108
// build the mule application via maven
109109
tasks.register('mvnPackage', Exec) {
110110
workingDir "$appDir"
111-
commandLine 'mvn', "-Ddatadog.builddir=$buildDir", "-Ddatadog.name=mule-test-application", "-Ddatadog.version=$version", 'package'
111+
commandLine "$rootDir/mvnw", "-Ddatadog.builddir=$buildDir", "-Ddatadog.name=mule-test-application", "-Ddatadog.version=$version", 'package'
112112
outputs.dir("$buildDir/target")
113113
inputs.dir("$appDir/src")
114114
inputs.file("$appDir/pom.xml")

‎dd-smoke-tests/springboot-openliberty/springboot-openliberty.gradle

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ def jarName = "demo-open-liberty-app.jar"
1515
// compile the Open liberty spring boot server
1616
tasks.register('mvnStage', Exec) {
1717
workingDir "$appDir"
18-
commandLine './mvnw', 'package'
18+
commandLine "$rootDir/mvnw", 'package'
1919
}
2020

2121
tasks.named("compileTestGroovy").configure {
File renamed without changes.
File renamed without changes.

0 commit comments

Comments
 (0)
Please sign in to comment.