Merge pull request DataDog#4228 from DataDog/jpbempel/rate-limiting-no-condition

Modify rate limit regarding probe conditions

Author: jpbempel

dd-java-agent/agent-debugger/debugger-bootstrap/src/main/java/datadog/trace/bootstrap/debugger/Snapshot.java

@@ -181,9 +181,12 @@ public void commit() {
       }
       return;
     }
-    if (!ProbeRateLimiter.tryProbe(probe.id)) {
-      DebuggerContext.skipSnapshot(probe.id, DebuggerContext.SkipCause.RATE);
-      return;
+    // only rate limit if a condition is defined
+    if (probe.getScript() != null) {
+      if (!ProbeRateLimiter.tryProbe(probe.id)) {
+        DebuggerContext.skipSnapshot(probe.id, DebuggerContext.SkipCause.RATE);
+        return;
+      }
     }
     // generates id only when effectively committing
     this.id = UUID.randomUUID().toString();

dd-java-agent/agent-debugger/debugger-bootstrap/src/main/java/datadog/trace/bootstrap/debugger/SnapshotProvider.java

@@ -16,6 +16,13 @@ public static Snapshot newSnapshot(String uuid, Class<?> callingClass) {
       LOG.info("Cannot resolve the probe: {}", uuid);
       probeDetails = Snapshot.ProbeDetails.UNKNOWN;
     }
+    // only rate limit if no condition are defined
+    if (probeDetails.getScript() == null) {
+      if (!ProbeRateLimiter.tryProbe(probeDetails.getId())) {
+        DebuggerContext.skipSnapshot(probeDetails.getId(), DebuggerContext.SkipCause.RATE);
+        return null;
+      }
+    }
     return new Snapshot(Thread.currentThread(), probeDetails, callingClass.getTypeName());
   }
 }