Fix randomization bug in GenerateRandomPassword function.

fadiksho · jasontaylordev · commit bb2de1a10197 · 2023-09-25T09:47:40.000+10:00
diff --git a/.scripts/setup.ps1 b/.scripts/setup.ps1
@@ -170,7 +170,7 @@ function GenerateRandomPassword {
     [int]$Length = 16
   )
 
-  $ValidChars = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789!#^_-+=?<>|~"
+  $ValidChars = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789!#^_-+=?<>|~".ToCharArray()
   $Password = -join ((Get-Random -Count $Length -InputObject $ValidChars) | Get-Random -Count $Length)
 
   return $Password

Original file line number	Diff line number	Diff line change
`@@ -170,7 +170,7 @@ function GenerateRandomPassword {`
`170`	`170`	`[int]$Length = 16`
`171`	`171`	`)`
`172`	`172`
`173`		`- $ValidChars = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789!#^_-+=?<>\|~"`
	`173`	`+ $ValidChars = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789!#^_-+=?<>\|~".ToCharArray()`
`174`	`174`	`$Password = -join ((Get-Random -Count $Length -InputObject $ValidChars) \| Get-Random -Count $Length)`
`175`	`175`
`176`	`176`	`return $Password`