Skip to content
This repository was archived by the owner on Mar 13, 2020. It is now read-only.

Commit cdd0aa4

Browse files
authored
Merge pull request #31 from Mawi137/master
Fix headers already sent error when exchanging code for token fails
2 parents 3e0f906 + 43f5d16 commit cdd0aa4

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

routes/authorize.js

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,13 @@ router.get('/', async function(req, res, next) {
1010

1111
// If code is present, use it
1212
if (code) {
13-
let token;
14-
1513
try {
16-
token = await authHelper.getTokenFromCode(code, res);
14+
await authHelper.getTokenFromCode(code, res);
15+
// Redirect to home
16+
res.redirect('/');
1717
} catch (error) {
1818
res.render('error', { title: 'Error', message: 'Error exchanging code for token', error: error });
1919
}
20-
21-
// Redirect to home
22-
res.redirect('/');
2320
} else {
2421
// Otherwise complain
2522
res.render('error', { title: 'Error', message: 'Authorization error', error: { status: 'Missing code parameter' } });

0 commit comments

Comments
 (0)