This repository has been archived by the owner on Feb 9, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 166
Create gitlab register component template #174
Open
Zaperex
wants to merge
20
commits into
janus-idp:main
Choose a base branch
from
Zaperex:create-gitlab-register-component-template
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Create gitlab register component template #174
Zaperex
wants to merge
20
commits into
janus-idp:main
from
Zaperex:create-gitlab-register-component-template
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schultzp2020
approved these changes
Sep 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
schultzp2020
suggested changes
Sep 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the READMEs to include the following information:
- How to use the GPT with a description on each field input
- How to test the GPT
Zaperex
force-pushed
the
create-gitlab-register-component-template
branch
from
September 22, 2023 20:57
dd9e860
to
e416e17
Compare
schultzp2020
suggested changes
Oct 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do / why we need it
Adds a GPT for registering existing components from a Gitlab repository
Additionally, adds input validation for the entity name of the registered component.
Which issue(s) does this PR fix
Partially fixes #163
Fixes: #184
How to test changes / Special notes to the reviewer