Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): allow release prefixes on pull request titles #2096

Conversation

christoph-jerolimov
Copy link
Member

Description

Hi @schultzp2020, this extra configuration to the Conventional Commits check will allow /cherry-pick PRs without renaming them.

This should work with this change:

fix: a small bugfix 
[release-1.4] fix: a small bugfix 
[WIP] [release-1.4] fix: a small bugfix 

The headerPattern default is defined here https://github.com/conventional-changelog/conventional-changelog/blob/master/packages/conventional-commits-parser/src/options.ts#L17

And I added the optional support for [release-/d+./d+] prefix.

Which issue(s) does this PR fix

  • Fixes #?

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

I've tested the workflow here https://github.com/christoph-jerolimov/conventionalcommit-test/pulls

Copy link
Collaborator

@schultzp2020 schultzp2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Dec 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: schultzp2020

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@schultzp2020 schultzp2020 merged commit 1d11c0a into redhat-developer:main Dec 11, 2024
9 of 10 checks passed
@christoph-jerolimov christoph-jerolimov deleted the allow-release-prefix-on-prs branch December 11, 2024 23:06
@christoph-jerolimov
Copy link
Member Author

/cherry-pick release-1.4

@openshift-cherrypick-robot
Copy link
Contributor

@christoph-jerolimov: new pull request created: #2097

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@nickboldt
Copy link
Member

/cherry-pick release-1.3

@openshift-cherrypick-robot
Copy link
Contributor

@nickboldt: #2096 failed to apply on top of branch "release-1.3":

Applying: chore(ci): allow release prefixes on pull request titles
Using index info to reconstruct a base tree...
A	.github/workflows/pr-semantic.yaml
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): .github/workflows/pr-semantic.yaml deleted in HEAD and modified in chore(ci): allow release prefixes on pull request titles. Version chore(ci): allow release prefixes on pull request titles of .github/workflows/pr-semantic.yaml left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 chore(ci): allow release prefixes on pull request titles

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants