-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(e2e): enable pipeline execution and pipeline operator installation #1985
base: main
Are you sure you want to change the base?
Conversation
Uncommented the code responsible for applying pipeline resources to ensure the hello-world pipeline runs as expected. Restored the install_pipelines_operator function to automate the installation of the Pipeline Operator. Signed-off-by: Gustavo Lira <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The image is available at: |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you enable OpenShift pipelines, please enable also Tekton Pipelines for Kubernetes tests (AKS and GKE).
Feel free to cherry pick this commit that does that: zdrapela@0036f7d
@zdrapela why do we need |
Because OpenShift pipelines doesn't work on Kubernetes (like AKS and GKE), but Tekton pipelines works (that's upstream of OpenShift pipelines). |
@gustavolira: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Uncommented the code responsible for applying pipeline resources to ensure the hello-world pipeline runs as expected. Restored the install_pipelines_operator function to automate the installation of the Pipeline Operator.
Description
Please explain the changes you made here.
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer