Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(e2e): enable pipeline execution and pipeline operator installation #1985

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gustavolira
Copy link
Contributor

Uncommented the code responsible for applying pipeline resources to ensure the hello-world pipeline runs as expected. Restored the install_pipelines_operator function to automate the installation of the Pipeline Operator.

Description

Please explain the changes you made here.

Which issue(s) does this PR fix

  • Fixes #?

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Uncommented the code responsible for applying pipeline resources to ensure the hello-world pipeline runs as expected. Restored the install_pipelines_operator function to automate the installation of the Pipeline Operator.

Signed-off-by: Gustavo Lira <[email protected]>
@gustavolira gustavolira requested a review from a team as a code owner November 25, 2024 18:36
Copy link

openshift-ci bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from gustavolira. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gustavolira gustavolira changed the title Enable pipeline execution and pipeline operator installation chore(e2e): enable pipeline execution and pipeline operator installation Nov 25, 2024
Copy link
Contributor

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@zdrapela zdrapela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you enable OpenShift pipelines, please enable also Tekton Pipelines for Kubernetes tests (AKS and GKE).
Feel free to cherry pick this commit that does that: zdrapela@0036f7d

@gustavolira
Copy link
Contributor Author

@zdrapela why do we need Tekton Pipelines ?

@zdrapela
Copy link
Member

@zdrapela why do we need Tekton Pipelines ?

Because OpenShift pipelines doesn't work on Kubernetes (like AKS and GKE), but Tekton pipelines works (that's upstream of OpenShift pipelines).

Copy link

openshift-ci bot commented Dec 10, 2024

@gustavolira: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests 9499d8e link true /test e2e-tests
ci/prow/images 9499d8e link true /test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants