Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sorting breaks when comment unavailable #9

Open
janschill opened this issue Mar 24, 2021 · 2 comments
Open

Sorting breaks when comment unavailable #9

janschill opened this issue Mar 24, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@janschill
Copy link
Owner

Extract time from comment file name and add to the comment object.
Careful, because then the comment object is not empty anymore and the rendering of the empty comment HTML needs to be caught differently.
@janschill
Copy link
Owner Author

Temporarily solved by reversing the fetched comments and add in the beginning of the comments array on a new comment submission.

@janschill
Copy link
Owner Author

This solution depends on the order the comments are persisted in the application.

@janschill janschill added the enhancement New feature or request label Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@janschill