Skip to content

Commit a2054e3

Browse files
authored
test-backend-ops : fix segfault in moe-expert-reduce test in support mode and coverage (ggml-org#16936)
* tests: fix segfault in moe-expert-reduce test in support mode and --show-coverage * tests: init gf and filter out fusion tests for support mode * tests: filter out fusion cases before calling eval_support * tests: filter out fusion cases from show_test_coverage as well, fix lint
1 parent dd52868 commit a2054e3

File tree

1 file changed

+19
-0
lines changed

1 file changed

+19
-0
lines changed

tests/test-backend-ops.cpp

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1454,6 +1454,8 @@ struct test_case {
14541454
ggml_context_ptr ctx(ggml_init(params)); // smart ptr
14551455
GGML_ASSERT(ctx);
14561456

1457+
gf = ggml_new_graph_custom(ctx.get(), graph_nodes, false);
1458+
14571459
ggml_tensor * out = build_graph(ctx.get());
14581460
current_op_name = op_desc(out);
14591461

@@ -7569,6 +7571,15 @@ static bool test_backend(ggml_backend_t backend, test_mode mode, const char * op
75697571
if (mode == MODE_SUPPORT) {
75707572
auto test_cases = make_test_cases_eval();
75717573
filter_test_cases(test_cases, params_filter);
7574+
7575+
// Filter out fusion cases
7576+
test_cases.erase(
7577+
std::remove_if(test_cases.begin(), test_cases.end(), [](const std::unique_ptr<test_case> & tc) {
7578+
return tc->run_whole_graph();
7579+
}),
7580+
test_cases.end()
7581+
);
7582+
75727583
for (auto & test : test_cases) {
75737584
test->eval_support(backend, op_names_filter, output_printer);
75747585
}
@@ -7619,6 +7630,14 @@ static void show_test_coverage() {
76197630
all_ops.insert(ggml_glu_op_name((enum ggml_glu_op)i));
76207631
}
76217632
auto test_cases = make_test_cases_eval();
7633+
// Filter out fusion cases
7634+
test_cases.erase(
7635+
std::remove_if(test_cases.begin(), test_cases.end(), [](const std::unique_ptr<test_case> & tc) {
7636+
return tc->run_whole_graph();
7637+
}),
7638+
test_cases.end()
7639+
);
7640+
76227641
std::set<std::string> tested_ops;
76237642

76247643
ggml_init_params params = {

0 commit comments

Comments
 (0)