Merge pull request #96 from reneolivo/missing-tests

Missing tests for example directive and service

Author: jakemmarsh

app/js/directives/example.js

@@ -4,16 +4,20 @@ function ExampleDirective() {
 
   return {
     restrict: 'EA',
-    link: (scope, element) => {
+    templateUrl: 'directives/example.html',
+    scope: {
+      title: '@',
+      message: '@exampleDirective'
+    },
+    link: (scope, element, attrs) => {
       element.on('click', () => {
-        console.log('element clicked');
+        alert('Element clicked: ' + scope.message);
       });
     }
   };
-
 }
 
 export default {
   name: 'exampleDirective',
   fn: ExampleDirective
-};
+};

app/views/directives/example.html

@@ -0,0 +1,3 @@
+<div class="example-directive">
+  <h1>{{title}}</h1>
+</div>

package.json

@@ -74,7 +74,7 @@
   "scripts": {
     "pretest": "npm install",
     "test": "karma start test/karma.conf.js",
-    "preprotractor": "npm run update-webdriver",
-    "protractor": "npm run protractor test/protractor.conf.js"
+    "preprotractor": "npm install && webdriver-manager update",
+    "protractor": "protractor test/protractor.conf.js"
   }
 }

test/protractor.conf.js

@@ -8,7 +8,7 @@ exports.config = {
 
   allScriptsTimeout: 11000,
 
-  baseUrl: 'http://localhost:' + gulpConfig.UIPort + '/',
+  baseUrl: 'http://localhost:' + gulpConfig.browserPort + '/',
 
   directConnect: true,
 
@@ -31,4 +31,4 @@ exports.config = {
     'e2e/**/*.js'
   ]
 
-};
+};

test/unit/directives/example_spec.js

@@ -0,0 +1,39 @@
+/*global angular, module, browser*/
+
+'use strict';
+
+describe('Unit: ExampleDirective', function() {
+
+  var element, scope;
+
+  beforeEach(function() {
+    spyOn(window, 'alert');
+    angular.mock.module('app');
+
+    angular.mock.inject(function($compile, $rootScope) {
+      scope = $rootScope;
+      element = angular.element('<div example-directive="{{message}}" title="{{title}}">Sample Directive</div>');
+      scope.title = "A sample title";
+      scope.message = "It doesn't hurt.";
+      $compile(element)(scope);
+      scope.$digest();
+    });
+  });
+
+  it('should bind itself to the element', function() {
+    element.triggerHandler('click');
+    expect(window.alert).toHaveBeenCalledWith("Element clicked: It doesn't hurt.");
+  });
+
+  it('should update its bindings', function() {
+    scope.message = "It hurts a bit.";
+    scope.$digest();
+    element.triggerHandler('click');
+    expect(window.alert).toHaveBeenCalledWith("Element clicked: It hurts a bit.");
+  });
+
+  it('should bind a title property to its template', function() {
+    expect(element.find('h1').text()).toBe('A sample title');
+  });
+
+});

test/unit/services/example_spec.js

@@ -4,14 +4,15 @@
 
 describe('Unit: ExampleService', function() {
 
-  var service;
+  var http, service;
 
   beforeEach(function() {
     // instantiate the app module
     angular.mock.module('app');
 
     // mock the service
-    angular.mock.inject(function(ExampleService) {
+    angular.mock.inject(function($httpBackend, ExampleService) {
+      http = $httpBackend;
       service = ExampleService;
     });
   });
@@ -20,4 +21,15 @@ describe('Unit: ExampleService', function() {
     expect(service).toBeDefined();
   });
 
-});
+  it('should retrieve data', function(done) {
+    http.expect('GET', 'apiPath').respond(201, {data: 1234});
+
+    service.get().then(function(result) {
+      expect(result).toEqual({data: 1234});
+    }, function(error) {
+      expect(error).toBeUndefined();
+    }).then(done);
+
+    http.flush();
+  });
+});