Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data type metadata should be included in cache node objects #30

Open
jakekgrog opened this issue Jul 16, 2020 · 3 comments
Open

Data type metadata should be included in cache node objects #30

jakekgrog opened this issue Jul 16, 2020 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jakekgrog
Copy link
Owner

jakekgrog commented Jul 16, 2020 •
edited
Loading

Now that we support more than 1 data type, we should include the values data type in cache nodes. This give us a way of easily identifying what type of data a key points to e.g. string, queue (and more types in the future)

Currently a cache node object consists of a Key, a Value and a TTL. We should also add a field specifying the type of the Value
@jakekgrog jakekgrog added enhancement New feature or request good first issue Good for newcomers labels Jul 16, 2020
@priyanka-tw
Copy link

Hi, I can work on this if it's still available.

@lucasnorman
Copy link

Does this still need to be worked on? If so are you open to any PRs at the moment?

@jakekgrog
Copy link
Owner Author

Hey @lucasnorman, we reverted a lot of changes so that we could overhaul how we handle distribution. As a result we don't have multiple datatypes at the moment. However, we'll be adding them back in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jakekgrog @lucasnorman @priyanka-tw