-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow to set password-protected notes #1481
base: v4
Are you sure you want to change the base?
Conversation
5a27b0a
to
bdc09c9
Compare
While I think this solution is great in what it does, I wouldn't recommend relying on it to keep anything safe. This is mostly for two reasons:
Having said all that, I do think that your solution has value, as password-encrypted static site can only get about as secure as your solution without external tooling/authentication. I feel like the documentation should reflect that, and I feel like we shouldn't be recommending users to deploy encrypted secret company documentation or medical records in the documentation. |
I just want to quickly chime in. For Quartz itself, I don't see any sort of SOC-2 compliant or adjacent security folks would use for hosting private and internal documentation (though we live in a society). This is still a good POC imo. |
a9e390b
to
18ded6d
Compare
@saberzero1 @aarnphm I updated documentation and put some recommendations from you |
440d910
to
717f2e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tbh this can also just be kept as reference for ppl who wants to add this to there vault.
Personally I don't really find a wide usage for this.
im happy to include it, we have quite a few reqs for this feature been swamped the last few days but can do a quick review later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To keep minimal change, I suggest we do locale in separate PR as follow up.
We can add support for Vietnamese and English should be good to start with
e567d97
to
9f53862
Compare
How about this PR @jackyzha0? Do you want to change anything? |
came here through the search. @jackyzha0, let's get it in please 🙌 |
Came here via searching for this feature. Thanks @dynamotn My use case is: sharing some notes with friends, but I don't want it to be accessible to everyone. I understand that if someone really wants to, they can get through, but that's okay. Won't put anything that sensitive here. Looking forward to this! |
This PR resolve #637.
Demo
https://notes.dynamotn.dev/01_Fleeting-Notes/20240505093315 with password
123451
How it works