Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests on CI #67

Open
rettinghaus opened this issue Jun 17, 2024 · 2 comments
Open

Fix tests on CI #67

rettinghaus opened this issue Jun 17, 2024 · 2 comments

Comments

@rettinghaus
Copy link
Contributor

It seems like test only run properly for owners of the repo. Tests are green on my fork, but they fail here for PRs.

@ColeDCrawford
Copy link
Contributor

ColeDCrawford commented Jun 27, 2024

For a while there was an issue on my fork when the workflow attempted to publish benchmark results to a non-existent Github Pages site, but I fixed that. I am also experiencing failing tests at the "Pytest comment" step during PRs from forks. Reruns of the CI workflow use "the privileges of the actor who initially triggered the workflow, not the privileges of the actor who initiated the re-run" (docs) so that's not a manual option either.

We could try changing the workflow to use the fork's context (where contributors have permission) by running it on pull_request_target? That seems less than ideal. Otherwise I think we would need to move the Pytest coverage comment step. @aweakley any thoughts?

@aweakley
Copy link
Member

Could we skip the pytest comment step unless it's the main branch maybe?
Also the combined coverage report is a bit confusing https://github.com/ixc/python-edtf/actions/runs/10395598114/job/28787984733#step:9:16 because it lists the files from the two sets of tests separately rather than properly combining them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants