Skip to content

paginationWaitingView is not required #4

@geminiyellow

Description

@geminiyellow

@iwater

when i copy the example from README, got this warning,

Warning: Failed prop type: The prop `paginationWaitingView` is marked as required in `GiftedVirtualizedList`, but its value is `undefined`.

yes, in here, it is isRequired,

paginationWaitingView: PropTypes.func.isRequired,

but, where it used,

here:

paginationWaitingView: PropTypes.func,

and default:

static defaultProps = {
paginationWaitingView: noop,
}

so, i think you should remove the isRequired from API.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions