Skip to content

Brigita review #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lmichel merged 10 commits into from
Jan 28, 2026
Merged

Brigita review #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0d24300
table 1 examples
lmichel Jan 28, 2026
3d2dedf
remove mention of alphabetical order
lmichel Jan 28, 2026
86057c8
trigger on pr-1.0 and brigita_review
lmichel Jan 28, 2026
775dec8
trigger on pr-1.0 and brigita_review
lmichel Jan 28, 2026
77bf9b5
diagram update
lmichel Jan 28, 2026
5eeab8d
Merge branch 'brigita_review' of [email protected]:lmichel/MANGO.git int…
lmichel Jan 28, 2026
f4c1454
set cardinality=1-1 to both mango:EpochPosition.spaceSys and timeSys -
lmichel Jan 28, 2026
426c90d
change date
lmichel Jan 28, 2026
19762cd
Merge branch 'brigita_review' of [email protected]:lmichel/MANGO.git int…
lmichel Jan 28, 2026
3a09d50
update the description of the mangoObjects association
lmichel Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/preview.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,7 @@ env:
on:
push:
branches:
- master
- wd-v1.0
- dal-review
- brigita_review
- pr-1.0

jobs:
Expand Down
3 changes: 2 additions & 1 deletion doc/.github/workflows/preview.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@ env:
on:
push:
branches:
- master
- pr-1.0
- brigita_review

jobs:
build:
Expand Down
10 changes: 5 additions & 5 deletions doc/MANGO.tex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,9 +292,9 @@ \subsection{Properties}
\hline
\texttt{EpochPosition} & Grouping of position with velocity and time & Parameters to solve the epoch propagation case\\
\hline
\texttt{Brightness} & Flux or Magnitude & many \\
\texttt{Brightness} & Flux or Magnitude & Object magnitude along with photometric calibration. \\
\hline
\texttt{Color} & Hardness ratio or magnitude ratio & many \\ [1ex]
\texttt{Color} & Hardness ratio or magnitude ratio & XMM-Newton hardness ratio, along with descriptions of the related energy bands. \\ [1ex]
\hline
\texttt{DataLink} & Flat representation of DataLink responses & Links to associated data given as column values\\ [1ex]
\hline
Expand All @@ -303,10 +303,10 @@ \subsection{Properties}
\label{table:properties}
\end{center}
\end{table}
This initial release supports a limited list of property types, listed in table \ref{table:properties}, that address the most common use cases.

All of these components are described in alphabetical order in the next section.
This initial release supports a limited list of property types, listed in table \ref{table:properties},
that address the most common use cases.

These components are all described individually in the following sections.

\subsubsection{Property Identification}
Since the set of properties associated with a particular instance is not defined by the model,
Expand Down
2 changes: 1 addition & 1 deletion doc/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ DOCNAME = MANGO
DOCVERSION = 1.0

# Publication date, ISO format; update manually for "releases"
DOCDATE = 2026-01-22
DOCDATE = 2026-01-28

# What is it you're writing: NOTE, WD, PR, REC, PEN, or EN
DOCTYPE = PR
Expand Down
4 changes: 2 additions & 2 deletions doc/ivoatexmeta.tex
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
% GENERATED FILE -- edit this in the Makefile
\newcommand{\ivoaDocversion}{1.0}
\newcommand{\ivoaDocdate}{2026-01-22}
\newcommand{\ivoaDocdatecode}{20260122}
\newcommand{\ivoaDocdate}{2026-01-28}
\newcommand{\ivoaDocdatecode}{20260128}
\newcommand{\ivoaDoctype}{PR}
\newcommand{\ivoaDocname}{MANGO}
\renewcommand{\ivoaBaseURL}{https://www.ivoa.net/documents/MANGO}
10 changes: 5 additions & 5 deletions doc/model.tex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,13 +243,13 @@ \section{Model: mango }
\subsubsection{EpochPosition.spaceSys}
\textbf{vodml-id: EpochPosition.spaceSys} \newline
\textbf{type: coords:SpaceSys} \newline
\textbf{multiplicity: 0..1} \newline
\textbf{multiplicity: 1} \newline
System that applies the space coordinates.

\subsubsection{EpochPosition.timeSys}
\textbf{vodml-id: EpochPosition.timeSys} \newline
\textbf{type: coords:TimeSys} \newline
\textbf{multiplicity: 0..1} \newline
\textbf{multiplicity: 1} \newline
System that applies the time coordinates (the epoch).

\subsection{EpochPositionCorrelations}
Expand Down Expand Up @@ -398,11 +398,11 @@ \section{Model: mango }
\textbf{multiplicity: 0..*} \newline
Contains the open-ended collection of the \texttt{MangoObject} properties (physical, calculated or assigned).

\subsubsection{MangoObject.associatedMangoObjects}
\textbf{vodml-id: MangoObject.associatedMangoObjects} \newline
\subsubsection{MangoObject.mangoObjects}
\textbf{vodml-id: MangoObject.mangoObjects} \newline
\textbf{type: \hyperref[sect:AssociatedMangoObject]{mango:AssociatedMangoObject}} \newline
\textbf{multiplicity: 0..*} \newline
Abstract reference to a particular dataset associated to the MANGO entity. This class is used to specify the type of the associated dataset as well as its role.
Reference to particular datasets (\texttt{mango:MangoObject} instances) that are associated with the MANGO object via \texttt{mango:AssociatedMangoObject} instances.

\subsubsection{MangoObject.queryOrigin}
\textbf{vodml-id: MangoObject.queryOrigin} \newline
Expand Down
10 changes: 5 additions & 5 deletions doc/model_toc.tex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@ \section{Model: mango}
\textbf{multiplicity: 0..*} \newline
Contains the open-ended collection of the \texttt{MangoObject} properties (physical, calculated or assigned).

\subsubsection{MangoObject.associatedMangoObjects}
\textbf{vodml-id: MangoObject.associatedMangoObjects} \newline
\subsubsection{MangoObject.mangoObjects}
\textbf{vodml-id: MangoObject.mangoObjects} \newline
\textbf{type: \hyperref[sect:AssociatedMangoObject]{mango:AssociatedMangoObject}} \newline
\textbf{multiplicity: 0..*} \newline
Abstract reference to a particular dataset associated to the MANGO entity. This class is used to specify the type of the associated dataset as well as its role.
Reference to particular datasets (\texttt{mango:MangoObject} instances) that are associated with the MANGO object via \texttt{mango:AssociatedMangoObject} instances.

\subsubsection{MangoObject.queryOrigin}
\textbf{vodml-id: MangoObject.queryOrigin} \newline
Expand Down Expand Up @@ -190,13 +190,13 @@ \section{Epoch Position Properties}
\subsubsection{EpochPosition.spaceSys}
\textbf{vodml-id: EpochPosition.spaceSys} \newline
\textbf{type: coords:SpaceSys} \newline
\textbf{multiplicity: 0..1} \newline
\textbf{multiplicity: 1} \newline
System that applies the space coordinates.

\subsubsection{EpochPosition.timeSys}
\textbf{vodml-id: EpochPosition.timeSys} \newline
\textbf{type: coords:TimeSys} \newline
\textbf{multiplicity: 0..1} \newline
\textbf{multiplicity: 1} \newline
System that applies the time coordinates (the epoch).

\subsection{EpochPositionCorrelations}
Expand Down
Binary file modified doc/role_diagram.pdf
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion mivot/mango/mango.AssociatedMangoObject.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ This class specifies both type and role of the property, and hosts the property
</COLLECTION>
</INSTANCE>
</COLLECTION>
<COLLECTION dmrole="mango:MangoObject.associatedMangoObjects">
<COLLECTION dmrole="mango:MangoObject.mangoObjects">
<INSTANCE dmtype="mango:AssociatedMangoObject"/>
</COLLECTION>
<INSTANCE dmrole="mango:MangoObject.queryOrigin" dmtype="mango:origin.QueryOrigin">
Expand Down
6 changes: 3 additions & 3 deletions mivot/mango/mango.MangoObject.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ This class specifies both type and role of the property, and hosts the property
</COLLECTION>
</INSTANCE>
</COLLECTION>
<COLLECTION dmrole="mango:MangoObject.associatedMangoObjects">
<INSTANCE dmrole="mango:MangoObject.associatedMangoObjects" dmtype="mango:AssociatedMangoObject">
<COLLECTION dmrole="mango:MangoObject.mangoObjects">
<INSTANCE dmrole="mango:MangoObject.mangoObjects" dmtype="mango:AssociatedMangoObject">
<!-- This class gives the role of a link associating 2 \texttt{MangoObject} together." -->
<INSTANCE dmrole="mango:AssociatedMangoObject.semantics" dmtype="mango:VocabularyTerm">
<!-- Class holder for a term of a standardized vocabulary that applies to a property." -->
Expand Down Expand Up @@ -68,7 +68,7 @@ This class specifies both type and role of the property, and hosts the property
</COLLECTION>
</INSTANCE>
</COLLECTION>
<COLLECTION dmrole="mango:MangoObject.associatedMangoObjects">
<COLLECTION dmrole="mango:MangoObject.mangoObjects">
<INSTANCE dmtype="mango:AssociatedMangoObject"/>
</COLLECTION>
<INSTANCE dmrole="mango:MangoObject.queryOrigin" dmtype="mango:origin.QueryOrigin">
Expand Down
Binary file modified model/EpochPosition.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading