Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] rotate the video according to its aspect ratio on mobile when in full screen #4861

Open
AnthillSudoku opened this issue Aug 19, 2024 · 5 comments
Labels
feature-request Request of a new feature module:player Impacts the video player of Invidious type:upstream The problem lies in one of the libraries, not in Invidious itself

Comments

@AnthillSudoku
Copy link

On android mobile, after pressing the full screen button a 1080x720 video is not shown in landscape but you have to change the entire device's orientation

Describe the solution you'd like

On full screen, the video is shown according to its aspect ratio without other interactions

Describe alternatives you've considered

A button in the navigation bar to change the orientation only of the video, and not the orientation of the app

Additional context

Screenshot_20240819-202942_Brave

@AnthillSudoku AnthillSudoku added the feature-request Request of a new feature label Aug 19, 2024
@AnthillSudoku
Copy link
Author

I just found that this behaviour is specific to Brave (chromium based) but not Firefox

@unixfox
Copy link
Member

unixfox commented Aug 20, 2024

That's an upstream issue with our video player library video.js

We have no control over this.

@unixfox unixfox closed this as not planned Won't fix, can't repro, duplicate, stale Aug 20, 2024
@SamantazFox SamantazFox reopened this Aug 20, 2024
@SamantazFox
Copy link
Member

Note: Reopening to mark is as upstream, and allow other users to find it easily

@SamantazFox SamantazFox added module:player Impacts the video player of Invidious type:upstream The problem lies in one of the libraries, not in Invidious itself labels Aug 20, 2024
@unixfox
Copy link
Member

unixfox commented Aug 20, 2024

maybe has been fixed by updating to video.js 8: #4439?

can you try @AnthillSudoku?

@AnthillSudoku
Copy link
Author

maybe has been fixed by updating to video.js 8: #443
can you try @AnthillSudoku?

I am not self hosting and this PR is a draft and not merged yet in master, so it has not been implemented in the public instances

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request of a new feature module:player Impacts the video player of Invidious type:upstream The problem lies in one of the libraries, not in Invidious itself
Projects
None yet
Development

No branches or pull requests

3 participants