Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not use green for feedback when no tests where executed #8

Open
mkarnicki opened this issue Apr 28, 2017 · 0 comments
Open

Should not use green for feedback when no tests where executed #8

mkarnicki opened this issue Apr 28, 2017 · 0 comments

Comments

@mkarnicki
Copy link

Hi and thanks for your sweet plugin :)

How to reproduce:

  1. Write a test
  2. Forget to annotate with /** @test */ and don't use test_ in name.
  3. Use the plugin to run it on a single test.

What happens:

  1. Plugin runs phpunit with --filter on the focused test.
  2. It shows a green pop-up (reminding the one when tests pass) that 'no tests were run'

What should happen:

  1. The plugin should probably use yellow color, just like phpunit, to make it clear that no tests where run. Using green can confuse the developer the test has run and passed. Sure, the box says no tests run, but it's way too easy to confuse passing with 'no tests run' right now. This is why phpunit uses a yellow background warning in the output "No tests executed!"

Thanks 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant