[RELEASE] iText 7 Core - 7.1.16

https://github.com/itext/itext7-dotnet/releases/tag/7.1.16

* release_branch_DEVSIX-5154:
  [RELEASE] 7.1.16
  Make EventData building based on IEvent synchronization independent from factory instance
  Perform scheduled check based on latest acquired Version instance
  Remove TODO related to already closed DEVSIX-5049
  Add support of attr() with type for url and string Add support of attr() with fallback for url and string Add support of attr() in target-counter Add tests
  Add missing copyright headers
  SVG: Add possibility to customize renderers for text chunks
  Prepare TargetCounterHandler to used from pure layout code
  Fix margin-border-padding widths for floating Text min-max-width calculation
  Rename #createDocument to #createDummyDocument in RendererUnitTest
  Fix some confusing Javadoc about OCSP
  Add DEVSIX reference to TODOs in tagging utilities for proper tags removal
  Improve StructTreeRoot documentation
  Improve GhostScript and ImageMagick util classes formatting and their tests
  Relax fuzziness parameter for ImageMagickHelper test
  Simplify ghostscript util test for -dSAFER command
  Replace ExpectedException.none to Assert.assertThrows
  Update autoported files
  Add support processing inline image with ICCBased color space in resources
  Add missing copyright headers
  Improve code coverage
  Add missing copyright headers
  Refactor preClose method in PdfSigner
  Add integration test for handling signatures with not merged widgets
  Add missing copyright headers
  Replace html2pdf-private tests: CssStyleAttributeParseTest
  Improve javadocs of TextRenderer
  Fix constructor of PdfReader to close() the PdfTokenizer when exception thrown Add PdfWriter/PdfReader/PdfDocument constructors to try-with-resources Add tests to compareLinkAnnotation method and encrypt method
  Improve javadocs for new code in Type3Font handling
  Set typo ascender/descender for type3 fonts based on font dictionary
  Add JavaUtil.Fill method overloads for different primitive types
  Remove TODOs from PdfTrueTypeFont class
  Cover AnnotationDefaultAppearance and PdfAction with documentation
  Cover Pdf3DAnnotation with javadocs
  Add missing copyright headers
  Support encrypting embedded files only
  Add overridden method without message for AssertThrows
  Improve the security of XML parsers
  Remove DTDs with non-existent reference from patterns in hyph module
  Add AssertUtil.cs with anolog of java's assertThrows method
  Add some tests on TextRenderer extensions. Add appropriate documentation.
  Log a message in case getNextRenderer is not overridden in an extended class. Improve its javadoc
  Improve FontSelector with comparing font weights
  Fix rounded border logic in layout
  Introduce lazy initialization for some of pdfDocument fields
  Remove redundant todo from deprecated method
  Add ImageTypeDetector's stream overload
  Implement unicode encoding for producer line in PDF
  Remove redundant mentions of SvgRegexUtils class
  Introduce support of intrinsic aspect ratio in flex algorithm
  Update port-hash after release
  [AFTER RELEASE] 7.1.15
  Remove Maven plugins: CheckStyle, PMD, SpotBugs
  Add tests on cells with big rowspan issues
  Add functionality to compare pdf signatures in tests
  Improve CssTypesValidation documentation
  Add tests to increase CrlClientOnline code coverage
  Get rid of new javadoc warnings
  Update port-hash
  Upgrade verapdf-validation-model to 1.18.2

Author: iText-CI

doxyfile

@@ -32,7 +32,7 @@ DOXYFILE_ENCODING      = UTF-8
 # title of most generated pages and in a few other places.
 # The default value is: My Project.
 
-PROJECT_NAME           = "iText 7 7.1.15 API"
+PROJECT_NAME           = "iText 7 7.1.16 API"
 
 # The PROJECT_NUMBER tag can be used to enter a project or revision number. This
 # could be handy for archiving the generated documentation or if some version

itext.tests/itext.barcodes.tests/Properties/AssemblyInfo.cs

@@ -14,9 +14,9 @@
 
 [assembly: Guid("d015a3aa-613c-45d9-b908-7d47c4b613af")]
 
-[assembly: AssemblyVersion("7.1.15.0")]
-[assembly: AssemblyFileVersion("7.1.15.0")]
-[assembly: AssemblyInformationalVersion("7.1.15")]
+[assembly: AssemblyVersion("7.1.16.0")]
+[assembly: AssemblyFileVersion("7.1.16.0")]
+[assembly: AssemblyInformationalVersion("7.1.16")]
 
 #if !NETSTANDARD2_0
 [assembly: NUnit.Framework.Timeout(300000)]

itext.tests/itext.barcodes.tests/itext/barcodes/BarcodeDataMatrixTest.cs

@@ -208,41 +208,32 @@ public virtual void Barcode11Test() {
 
         [NUnit.Framework.Test]
         public virtual void Barcode12Test() {
-            NUnit.Framework.Assert.That(() =>  {
-                BarcodeDataMatrix barcodeDataMatrix = new BarcodeDataMatrix();
-                barcodeDataMatrix.SetWidth(18);
-                barcodeDataMatrix.SetHeight(18);
-                byte[] str = "AbcdFFghijklmnop".GetBytes();
-                barcodeDataMatrix.SetCode(str, -1, str.Length);
-            }
-            , NUnit.Framework.Throws.InstanceOf<IndexOutOfRangeException>())
-;
+            BarcodeDataMatrix barcodeDataMatrix = new BarcodeDataMatrix();
+            barcodeDataMatrix.SetWidth(18);
+            barcodeDataMatrix.SetHeight(18);
+            byte[] str = "AbcdFFghijklmnop".GetBytes();
+            Exception e = NUnit.Framework.Assert.Catch(typeof(IndexOutOfRangeException), () => barcodeDataMatrix.SetCode
+                (str, -1, str.Length));
         }
 
         [NUnit.Framework.Test]
         public virtual void Barcode13Test() {
-            NUnit.Framework.Assert.That(() =>  {
-                BarcodeDataMatrix barcodeDataMatrix = new BarcodeDataMatrix();
-                barcodeDataMatrix.SetWidth(18);
-                barcodeDataMatrix.SetHeight(18);
-                byte[] str = "AbcdFFghijklmnop".GetBytes();
-                barcodeDataMatrix.SetCode(str, 0, str.Length + 1);
-            }
-            , NUnit.Framework.Throws.InstanceOf<IndexOutOfRangeException>())
-;
+            BarcodeDataMatrix barcodeDataMatrix = new BarcodeDataMatrix();
+            barcodeDataMatrix.SetWidth(18);
+            barcodeDataMatrix.SetHeight(18);
+            byte[] str = "AbcdFFghijklmnop".GetBytes();
+            NUnit.Framework.Assert.Catch(typeof(IndexOutOfRangeException), () => barcodeDataMatrix.SetCode(str, 0, str
+                .Length + 1));
         }
 
         [NUnit.Framework.Test]
         public virtual void Barcode14Test() {
-            NUnit.Framework.Assert.That(() =>  {
-                BarcodeDataMatrix barcodeDataMatrix = new BarcodeDataMatrix();
-                barcodeDataMatrix.SetWidth(18);
-                barcodeDataMatrix.SetHeight(18);
-                byte[] str = "AbcdFFghijklmnop".GetBytes();
-                barcodeDataMatrix.SetCode(str, 0, -1);
-            }
-            , NUnit.Framework.Throws.InstanceOf<IndexOutOfRangeException>())
-;
+            BarcodeDataMatrix barcodeDataMatrix = new BarcodeDataMatrix();
+            barcodeDataMatrix.SetWidth(18);
+            barcodeDataMatrix.SetHeight(18);
+            byte[] str = "AbcdFFghijklmnop".GetBytes();
+            NUnit.Framework.Assert.Catch(typeof(IndexOutOfRangeException), () => barcodeDataMatrix.SetCode(str, 0, -1)
+                );
         }
 
         [NUnit.Framework.Test]

itext.tests/itext.barcodes.tests/itext/barcodes/BarcodeEANUnitTest.cs

@@ -187,17 +187,14 @@ public virtual void GetBarcodeSizeSUPP2Test() {
 
         [NUnit.Framework.Test]
         public virtual void GetBarcodeSizeIncorrectTypeTest() {
-            NUnit.Framework.Assert.That(() =>  {
-                PdfDocument document = new PdfDocument(new PdfWriter(new MemoryStream()));
-                Barcode1D barcode = new BarcodeEAN(document);
-                barcode.SetCode("9781935182610");
-                // Set incorrect type
-                barcode.SetCodeType(1234);
-                // We do expect an exception here
-                barcode.GetBarcodeSize();
-            }
-            , NUnit.Framework.Throws.InstanceOf<PdfException>().With.Message.EqualTo("Invalid code type"))
-;
+            PdfDocument document = new PdfDocument(new PdfWriter(new MemoryStream()));
+            Barcode1D barcode = new BarcodeEAN(document);
+            barcode.SetCode("9781935182610");
+            // Set incorrect type
+            barcode.SetCodeType(1234);
+            // We do expect an exception here
+            Exception e = NUnit.Framework.Assert.Catch(typeof(PdfException), () => barcode.GetBarcodeSize());
+            NUnit.Framework.Assert.AreEqual("Invalid code type", e.Message);
         }
     }
 }

itext.tests/itext.barcodes.tests/itext/barcodes/BarcodePDF417Test.cs

@@ -315,19 +315,16 @@ public virtual void Barcode417OptionsWithBarcodeGenerationTest() {
 
         [NUnit.Framework.Test]
         public virtual void Barcode417OptionsWithBarcodeGenerationInvalidSizeTest() {
-            NUnit.Framework.Assert.That(() =>  {
-                MemoryStream baos = new MemoryStream();
-                PdfWriter writer = new PdfWriter(baos);
-                PdfDocument document = new PdfDocument(writer);
-                PdfPage page = document.AddNewPage();
-                PdfCanvas canvas = new PdfCanvas(page);
-                BarcodePDF417 barcode = new BarcodePDF417();
-                barcode.SetOptions(64);
-                barcode.PlaceBarcode(canvas, null);
-                NUnit.Framework.Assert.AreEqual(64, barcode.GetOptions());
-            }
-            , NUnit.Framework.Throws.InstanceOf<PdfException>().With.Message.EqualTo("Invalid codeword size."))
-;
+            MemoryStream baos = new MemoryStream();
+            PdfWriter writer = new PdfWriter(baos);
+            PdfDocument document = new PdfDocument(writer);
+            PdfPage page = document.AddNewPage();
+            PdfCanvas canvas = new PdfCanvas(page);
+            BarcodePDF417 barcode = new BarcodePDF417();
+            barcode.SetOptions(64);
+            Exception e = NUnit.Framework.Assert.Catch(typeof(PdfException), () => barcode.PlaceBarcode(canvas, null));
+            NUnit.Framework.Assert.AreEqual("Invalid codeword size.", e.Message);
+            NUnit.Framework.Assert.AreEqual(64, barcode.GetOptions());
         }
 
         private PdfFormXObject CreateMacroBarcodePart(PdfDocument document, String text, float mh, float mw, int segmentId

itext.tests/itext.forms.tests/Properties/AssemblyInfo.cs

@@ -14,9 +14,9 @@
 
 [assembly: Guid("6fe2f714-6b3e-4b20-8c70-28bfce084ed2")]
 
-[assembly: AssemblyVersion("7.1.15.0")]
-[assembly: AssemblyFileVersion("7.1.15.0")]
-[assembly: AssemblyInformationalVersion("7.1.15")]
+[assembly: AssemblyVersion("7.1.16.0")]
+[assembly: AssemblyFileVersion("7.1.16.0")]
+[assembly: AssemblyInformationalVersion("7.1.16")]
 
 #if !NETSTANDARD2_0
 [assembly: NUnit.Framework.Timeout(300000)]

itext.tests/itext.forms.tests/itext/forms/XfdfUnitTest.cs

@@ -20,19 +20,16 @@ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 You should have received a copy of the GNU Affero General Public License
 along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */
+using System;
 using iText.Forms.Xfdf;
 using iText.Test;
 
 namespace iText.Forms {
     public class XfdfUnitTest : ExtendedITextTest {
         [NUnit.Framework.Test]
         public virtual void FitObjectWithEmptyPageTest() {
-            NUnit.Framework.Assert.That(() =>  {
-                FitObject fitObject = new FitObject(null);
-                NUnit.Framework.Assert.Fail();
-            }
-            , NUnit.Framework.Throws.InstanceOf<XfdfException>().With.Message.EqualTo(XfdfException.PAGE_IS_MISSING))
-;
+            Exception e = NUnit.Framework.Assert.Catch(typeof(XfdfException), () => new FitObject(null));
+            NUnit.Framework.Assert.AreEqual(XfdfException.PAGE_IS_MISSING, e.Message);
         }
     }
 }

itext.tests/itext.forms.tests/itext/forms/XfdfWriterTest.cs

@@ -955,21 +955,21 @@ public virtual void XfdfDropDown() {
 
         [NUnit.Framework.Test]
         public virtual void XfdfEmptyAttributeTest() {
-            NUnit.Framework.Assert.That(() =>  {
-                XfdfObject xfdfObject = new XfdfObject();
-                AnnotsObject annots = new AnnotsObject();
-                xfdfObject.SetAnnots(annots);
-                AnnotObject annot = new AnnotObject();
-                annots.AddAnnot(annot);
-                String namePresent = "name1";
-                String nameAbsent = null;
-                String valuePresent = "value";
-                String valueAbsent = null;
-                annot.AddAttribute(new AttributeObject(nameAbsent, valuePresent));
-                annot.AddAttribute(new AttributeObject(namePresent, valueAbsent));
-            }
-            , NUnit.Framework.Throws.InstanceOf<XfdfException>().With.Message.EqualTo(XfdfException.ATTRIBUTE_NAME_OR_VALUE_MISSING))
-;
+            XfdfObject xfdfObject = new XfdfObject();
+            AnnotsObject annots = new AnnotsObject();
+            xfdfObject.SetAnnots(annots);
+            AnnotObject annot = new AnnotObject();
+            annots.AddAnnot(annot);
+            String namePresent = "name1";
+            String nameAbsent = null;
+            String valuePresent = "value";
+            String valueAbsent = null;
+            Exception e = NUnit.Framework.Assert.Catch(typeof(XfdfException), () => annot.AddAttribute(new AttributeObject
+                (nameAbsent, valuePresent)));
+            NUnit.Framework.Assert.AreEqual(XfdfException.ATTRIBUTE_NAME_OR_VALUE_MISSING, e.Message);
+            Exception e2 = NUnit.Framework.Assert.Catch(typeof(XfdfException), () => annot.AddAttribute(new AttributeObject
+                (namePresent, valueAbsent)));
+            NUnit.Framework.Assert.AreEqual(XfdfException.ATTRIBUTE_NAME_OR_VALUE_MISSING, e2.Message);
         }
     }
 }

itext.tests/itext.forms.tests/itext/forms/xfa/SecurityTestXmlParserFactory.cs

@@ -0,0 +1,81 @@
+/*
+This file is part of the iText (R) project.
+    Copyright (c) 1998-2021 iText Group NV
+Authors: iText Software.
+
+This program is free software; you can redistribute it and/or modify
+it under the terms of the GNU Affero General Public License version 3
+as published by the Free Software Foundation with the addition of the
+following permission added to Section 15 as permitted in Section 7(a):
+FOR ANY PART OF THE COVERED WORK IN WHICH THE COPYRIGHT IS OWNED BY
+ITEXT GROUP. ITEXT GROUP DISCLAIMS THE WARRANTY OF NON INFRINGEMENT
+OF THIRD PARTY RIGHTS
+
+This program is distributed in the hope that it will be useful, but
+WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
+or FITNESS FOR A PARTICULAR PURPOSE.
+See the GNU Affero General Public License for more details.
+You should have received a copy of the GNU Affero General Public License
+along with this program; if not, see http://www.gnu.org/licenses or write to
+the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
+Boston, MA, 02110-1301 USA, or download the license from the following URL:
+http://itextpdf.com/terms-of-use/
+
+The interactive user interfaces in modified source and object code versions
+of this program must display Appropriate Legal Notices, as required under
+Section 5 of the GNU Affero General Public License.
+
+In accordance with Section 7(b) of the GNU Affero General Public License,
+a covered work must retain the producer line in every PDF that is created
+or manipulated using iText.
+
+You can be released from the requirements of the license by purchasing
+a commercial license. Buying such a license is mandatory as soon as you
+develop commercial activities involving the iText software without
+disclosing the source code of your own applications.
+These activities include: offering paid services to customers as an ASP,
+serving PDFs on the fly in a web application, shipping iText with a closed
+source product.
+
+For more information, please contact iText Software Corp. at this
+address: [email protected]
+*/
+
+using System;
+using System.IO;
+using System.Xml;
+using iText.Kernel;
+using iText.Kernel.Utils;
+
+namespace iText.Forms.Xfa
+{
+    public class SecurityTestXmlParserFactory : IXmlParserFactory
+    {
+        private XmlReaderSettings xmlReaderSettings;
+
+        public SecurityTestXmlParserFactory()
+        {
+            xmlReaderSettings = new XmlReaderSettings();
+            xmlReaderSettings.DtdProcessing = DtdProcessing.Parse;
+            xmlReaderSettings.XmlResolver = new TestXmlResolver();
+        }
+
+        public XmlReader CreateXmlReaderInstance(Stream stream, XmlParserContext inputContext)
+        {
+            return XmlReader.Create(stream, xmlReaderSettings);
+        }
+
+        public XmlReader CreateXmlReaderInstance(TextReader textReader)
+        {
+            return XmlReader.Create(textReader, xmlReaderSettings);
+        }
+
+        private class TestXmlResolver : XmlResolver
+        {
+            public override object GetEntity(Uri absoluteUri, string role, Type ofObjectToReturn)
+            {
+                throw new PdfException("Test message");
+            }
+        }
+    }
+}