wrong time range - rounding up

[SabrielxD]

This is an issue we experienced last week with the Eawag people while analyzing their files.
An example file can be found here:

• the analysis time is 5 min but the last data point is at 5.001 min;
• in the GUI, the time range is set automatically to 0 to 6 min after uploading the file, most probably due to rounding up:

So after pressing "Start", it produces an error "Input Time [min]: Second value exceeds data in uploaded isox files." and the second time window has to be always manually rewritten to 5.

[SabrielxD]

I think this is caused by value = 0:ceiling(max(values$data$time.min)) on line 210 in the file isoorbiGUI/R/gui_module_isoxl_single.R

Same issue is on line 199 in the file isoorbiGUI/R/gui_module_isoxl_shotnoise.R
and line 195 in the file isoorbiGUI/R/gui_module_isoxl_flow.R

[SabrielxD]

I think it would be better to use round instead of ceiling here?

[sebkopf]

i'm confused why having a larger max time than exists in the dataset should throw an error though? isn't it always okay to have a filter(time.min < max_time) even if max_time is larger than the max in the dataset? the problem with rounding if we want even numbers is that rounding 5.3 to 5 means users can never see the data above 5 mins unless we permit decimal places in the time range

[123caj]

Both correct, I think. The issue is that rounding up triggers an UI input check in req(input$timerange1[2] <= max(values$data$time.min)+0.05) #give a bit leeway.

For now, I have changed the Direct Infusion module to:

      shinyWidgets::updateNumericRangeInput(session,
                                            inputId = "timerange",
                                            value = c(min(values$data$time.min), max(values$data$time.min))

[sebkopf]

I'm still confused why wee need that UI input check, are you worried users wouldn't realize they're requesting more data than is available?

[123caj]

Thinking it's good to have a lower and upper bound for inputs. Could be set up as a warning, not req()....

…

On Sun, Oct 23, 2022, 11:20 AM Sebastian Kopf ***@***.***> wrote: I'm still confused why wee need that UI input check, are you worried users wouldn't realize they're requesting more data than is available? — Reply to this email directly, view it on GitHub <#37 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABJZ46HLZZOSYVW672Z7OA3WEVXU5ANCNFSM6AAAAAAQ53HIRQ> . You are receiving this because you commented.Message ID: ***@***.***>

[SabrielxD]

@123caj can you please check the implementation of this issue? Nora from Eawag has reported an error when the last scan in the isox file is 69.99X and the code expects 70. she has to then manually modify the last rows of all the isox files