Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin test runner does not clean up docker containers #193

Open
SwooshyCueb opened this issue Apr 25, 2024 · 2 comments
Open

Plugin test runner does not clean up docker containers #193

SwooshyCueb opened this issue Apr 25, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@SwooshyCueb
Copy link
Member

run_plugin_tests.py does not clean up after itself, leaving behind all of its temporary docker containers after exiting.
@alanking
Copy link
Contributor

I just had an unsuccessful run using run_plugin_tests.py and watched the containers stop and then they were removed. I'll keep an eye on the future runs to see if I see this issue.

@SwooshyCueb SwooshyCueb mentioned this issue Apr 25, 2024
Open
@SwooshyCueb
Copy link
Member Author

Turns out this only happens if an exception is thrown and not caught before cleanup happens (#196). We should do some try/finally magic to make sure this doesn't happen, and we should probably do it for the rest of our scripts too.

@alanking alanking added the bug Something isn't working label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SwooshyCueb @alanking