Improve recursiveSearchValues & update tests

Author: irodger

Readme.md

@@ -14,7 +14,8 @@ xlsx to JSON parser. Also support i18next format. Relies on node-xlsx.
 ### Yep, it can append new files to exist now! *Cheers* 😎
 
 ### What's new
-* v,0.3.3 - Update Readme.md
+* v.0.3.4 - Improve recursiveSearchValues & update tests
+* v.0.3.3 - Update Readme.md
 * v.0.3.2 - Fix known issues with one level template
 * v.0.3.1 - Update Readme.md
 * v.0.3.0 - Add config tests. Fix parser. Now it's work as NPM module correctly

__tests__/tests.js

@@ -55,8 +55,8 @@ describe('getValuesFromArray', () => {
     expect(recursiveSearchValues(mockSecondObj)).toEqual(mockSecondObj);
   });
 
-  it('recursiveSearchValues with empty object return undefined' , () => {
-    expect(recursiveSearchValues(emptyObj)).toEqual(undefined);
+  it('recursiveSearchValues with empty object return false' , () => {
+    expect(recursiveSearchValues(emptyObj)).toEqual(false);
   });
 
   it('is getConfig still object', () => {

package.json

@@ -1,6 +1,6 @@
 {
   "name": "xlsx-json-parser",
-  "version": "0.3.3",
+  "version": "0.3.4",
   "description": "Parse xls/xlsx to json. i18next format",
   "main": "index.js",
   "author": "Roman iRodger Dvoryanov <[email protected]> (http://irodger.ru)",

utils/getConfig.js

@@ -14,7 +14,7 @@ const config = {
   xlsxDir: path + (configFile.xlsxDir || selfConfig.xlsxDir) + '/',
   jsonDir: path + (configFile.jsonDir || selfConfig.jsonDir) + '/',
   fileTemplate(lang, template) {
-    return configFile.fileTemplate ? configFile.fileTemplate(lang, template) : selfConfig.fileTemplate(lang, template)
+    return configFile.fileTemplate ? configFile.fileTemplate(lang, template) : selfConfig.fileTemplate(lang, template);
   }
 };
 

utils/recursiveSearchValues.js

@@ -4,6 +4,8 @@
  * @returns boolean
  */
 function recursiveSearchValues (obj) {
+  if (!Object.keys(obj).length) return false;
+
   for(let key in obj) {
     if (obj.hasOwnProperty(key)) {
       if (typeof obj[key] === 'object') {
@@ -13,7 +15,7 @@ function recursiveSearchValues (obj) {
           return obj[key];
         }
       } else {
-        return obj
+        return obj;
       }
     } else {
       return false;