Integrate LLVM at 73f11ac #19941
Merged
Integrate LLVM at 73f11ac #19941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjacob
force-pushed
the
integrates/llvm-20250207
branch
2 times, most recently
from
b1733b6 to
3ca98e0
Compare
…] Use explicit namespace for OpTrait. (#126286) (Scott Todd on 2025-02-07 11:04:09 -0800) (11 of 15) Signed-off-by: Benoit Jacob <[email protected]>
bjacob
force-pushed
the
integrates/llvm-20250207
branch
from
3ca98e0 to
bb93eb4
Compare
Signed-off-by: Benoit Jacob <[email protected]>
bjacob
requested review from
antiagainst,
MaheshRavishankar,
kuhar,
qedawkins,
Groverkss,
hanhanW and
pashu123
as code owners
ScottTodd
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
Reverting llvm/llvm-project#125789 because it breaks TorchToTosa, in torch-mlir. We will need to wait for this to be resolved in torch-mlir, then simultaneously bump torch-mlir and drop the revert.
My change that we had cherrypicked was also due to changes in TorchToTosa. We don't currently use that component from torch-mlir in IREE AFAICT but we still pull in the source files. We may want to propose/implement a TORCH_MLIR_ENABLE_TOSA like TORCH_MLIR_ENABLE_STABLEHLO.
Signed-off-by: Benoit Jacob <[email protected]>
Signed-off-by: Benoit Jacob <[email protected]>
Signed-off-by: Benoit Jacob <[email protected]>
Signed-off-by: Benoit Jacob <[email protected]>
pashu123
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had previously cherry-picked llvm/llvm-project@73f11ac in #19939.
Now we're integrating up to that commit, so it's no longer a cherry-pick.
Reverting llvm/llvm-project#125789 because it breaks TorchToTosa, in torch-mlir. We will need to wait for this to be resolved in torch-mlir, then simultaneously bump torch-mlir and drop the revert.
Chery-pick a Bazel fix: llvm/llvm-project@4df287a