Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate llvm to llvm/llvm-project@a1984ec5eab09f #19934

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

hanhanW
Copy link
Contributor

@hanhanW hanhanW commented Feb 7, 2025

No description provided.

@hanhanW hanhanW marked this pull request as ready for review February 7, 2025 06:25
Copy link
Contributor

@pashu123 pashu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm curious, what was the reason for shifting from undefined to poison semantics?

@hanhanW
Copy link
Contributor Author

hanhanW commented Feb 7, 2025

LGTM! I'm curious, what was the reason for shifting from undefined to poison semantics?

I don't work on this area, but the upstream commit has the answer:

LLVM itself is generally moving away from using undef and towards
using poison, to the point of having a lint that caches new uses of
undef in tests.

In order to not trip the lint on new patterns and to conform to the
evolution of LLVM

  • Rename valious ::undef() methods on StructBuilder subclasses to
    ::poison()
  • Audit the uses of UndefOp in the MLIR libraries and replace almost all
    of them with PoisonOp

@hanhanW hanhanW enabled auto-merge (squash) February 7, 2025 06:57
@hanhanW hanhanW merged commit b5b943a into iree-org:main Feb 7, 2025
42 checks passed
@hanhanW hanhanW deleted the integrate-20250207 branch February 7, 2025 07:05
@kuhar
Copy link
Member

kuhar commented Feb 7, 2025

what was the reason for shifting from undefined to poison semantics?

undef is an llvm 3.x relict that's generally broken and difficult to optimize around, poison allows for more self-consistent rewrites: https://llvm.org/docs/UndefinedBehavior.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants