[CPU] Remove casting math.powf from fp16 to fp32 #19844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hyunsung Lee <[email protected]>
ita9naiwa
requested review from
hanhanW,
MaheshRavishankar and
pashu123
as code owners
bjacob
approved these changes
Jan 29, 2025
|
Let's wait for the change landed to IREE. I think it would take few days, and then you can rebase and retrigger the CI. Thanks for fixing it! |
ita9naiwa
force-pushed
the
ita9naiwa/remove-powf-fp16-f32
branch
from
9e63d0f to
ba8c1e9
Compare
|
the CI failed before because I removed some necessary part if (failed(applyPatternsGreedily(getOperation(), std::move(patterns)))) {
return signalPassFailure();
}I took it back and CI should work okay. |
ita9naiwa
force-pushed
the
ita9naiwa/remove-powf-fp16-f32
branch
from
ba8c1e9 to
236e5f7
Compare
ita9naiwa
requested review from
antiagainst,
nithinsubbiah,
benvanik,
kuhar,
rsuderman,
IanWood1,
qedawkins,
Groverkss,
ScottTodd and
stellaraccident
as code owners
ita9naiwa
force-pushed
the
ita9naiwa/remove-powf-fp16-f32
branch
from
236e5f7 to
ba8c1e9
Compare
Signed-off-by: Hyunsung Lee <[email protected]>
ita9naiwa
force-pushed
the
ita9naiwa/remove-powf-fp16-f32
branch
from
ba8c1e9 to
39db470
Compare
Signed-off-by: Hyunsung Lee <[email protected]>
ita9naiwa
force-pushed
the
ita9naiwa/remove-powf-fp16-f32
branch
from
39db470 to
bfdec6f
Compare
ita9naiwa
removed request for
benvanik,
antiagainst,
stellaraccident,
MaheshRavishankar,
ScottTodd and
kuhar
ita9naiwa
removed request for
rsuderman,
nithinsubbiah,
qedawkins,
Groverkss and
IanWood1
hanhanW
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #15936
once llvm/llvm-project#124402 gets merged,
we can remove
ExpandF16OpToF32Patternon math::PowFOp